| Summary: | Review request: west-chamber-kmod - Kernel module (kmod) for west-chamber | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Caius 'kaio' Chance <kaio> |
| Component: | Review Request | Assignee: | Chen Lei <supercyper1> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rpmfusion-package-review, supercyper1 |
| Priority: | P5 | ||
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| URL: | http://code.google.com/p/scholarzhang/ | ||
| namespace: | |||
| Bug Depends on: | |||
| Bug Blocks: | 4 | ||
|
Description
Caius 'kaio' Chance
2010-04-05 16:09:06 CEST
formal review here:
+:ok, =:needs attention, -:needs fixing
MUST Items:
[+] MUST: rpmlint must be run on every package.
<<output if not already posted>>
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
list and more]
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
<<md5sum checksum>>38d1503a1df5d8b5fa6823e3e0ed4982
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[N/A] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
================
*** APPROVED ***
================
Note: Please set "%define buildforkernels current" instead of "%define buildforkernels newest" the first time you import a module into rpmfusion. See http://rpmfusion.org/Packaging/KernelModules/Kmods2#head-998f6964b3188f6a2ac6e757ff14f0511b79ffb5 Package CVS request ====================== Package Name: west-chamber-kmod Short Description: Kernel module (kmod) for west-chamber Owners: kaio supercyper Branches: F-12 F-13 ---------------------- License tag: free |