Bug 18

Good work, I'm unfortunately to busy t review this, I just wanted to say keep up the good work!

I was the one who requested it. I'll try to review it maybe during the next weekend.

Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [!] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [!] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: f8/i386
 [x] Rpmlint output:
     Output is clean
 [x] Package is not relocatable.
 [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [!] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
     License type: GPLv2
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [!] Sources used to build the package matches the upstream source, as provided in the spec URL.
 [x] Package is not known to require ExcludeArch
 [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [-] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [!] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: f8/i386
 [!] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.


=== Issues ===
1. Package is not named according to guidelines:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a

Example (pre-release svn checkout):
autopano-sift-C-2-4.1.20080102svn


2. It seems to me that license is "GPLv2" and not "GPLv2 or later"

README says:     
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; version 2 of the License.

Header in most C files:
 * This program is free software released under the GNU General Public
 * License, which is included in this software package (doc/LICENSE).


3. Source 0 is not available
(http://prdownloads.sourceforge.net/hugin/autopano-sift-C-2.4.tar.gz)

Please see packaging guidelines on how to package svn checkouts:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49


4. Duplicate BuildRequires: zlib-devel (by libpng-devel), libpng-devel (by
libpano13-devel), libjpeg-devel (by libpano13-devel), libtiff-devel (by
libpano13-devel)


5. Do not package doc/autopano.txt doc/generatekeys.txt since these are just
text files converted from their man pages.


6. Is this package stable? I ask since I read the following in the REAME.1ST
file:

"These files have suddenly appeared on the hugin patches page. It has been
uploaded by an anonymous person. Thank you!

Unfortunately there still seems to be a subtle bug in the port. I have been
unable to locate this bug. If you do please let me know so that I can
add the patches and distribute the sourcecode."


7. I tried to follow this note (which should be in a README.fedora file):

"To use with hugin, set the 'Autopano-SIFT:' preference to
autopano-c-complete.sh"

but I cannot make it work with hugin. I get the following error when I try to make control points:

command:autopano-c-complete.sh --output /tmp/ap_res0pPXi3 --imagelist
/tmp/ap_imgnamestvdTle
fallito, codice errore:1


=== Final Notes ===
1. SIFT algorithm is patented (but it is fine since we are in RPM Fusion and
not in Fedora)


NEEDSWORK

(In reply to comment #3)
> 1. Package is not named according to guidelines:
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a
> 
> Example (pre-release svn checkout):
> autopano-sift-C-2-4.1.20080102svn

I mistyped. It should have been:

autopano-sift-C-2.4-0.1.20080102svn

Bye,

Andrea.

(In reply to comment #3)

Thanks for the review, updated SPEC and SRPMS here:
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/autopano-sift-C.spec
http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/8/x86_64/SRPMS.panorama/autopano-sift-C-2.4-4.1.20080102svn.fc8.src.rpm

> 1. Package is not named according to guidelines:
> autopano-sift-C-2.4-0.1.20080102svn

Ok, I've switched to the fedora naming scheme.  I've used post-release versioning even though there has never actually been a 2.4 release for two reasons:

1. I'm merging this from my existing 3rd party repo and numbering it 2.4-0.1 will break migration.
2. The formal upstream release is likely to be 2.5, so giving it a 'post-release' 2.4-4.1 number should be ok.

> 2. It seems to me that license is "GPLv2" and not "GPLv2 or later"

Well spotted, I was fooled by grepping for 'or later', FIXED.

> 3. Source 0 is not available
> 
> Please see packaging guidelines on how to package svn checkouts:

FIXED, should be done right now.

> 4. Duplicate BuildRequires: zlib-devel (by libpng-devel), libpng-devel (by
> libpano13-devel), libjpeg-devel (by libpano13-devel), libtiff-devel (by
> libpano13-devel)

FIXED

> 5. Do not package doc/autopano.txt doc/generatekeys.txt since these are just
> text files converted from their man pages.

FIXED/removed

> 6. Is this package stable? I ask since I read the following in the REAME.1ST
> file:
> 
> Unfortunately there still seems to be a subtle bug in the port. I have been
> unable to locate this bug.

Yes, not a great bug-report from Pablo, it should be removed as all it does it put people off and there have been some fixes since this was written.  I've been using this for a while and it doesn't have any more problems than autopano-sift (the original mono program).

> 7. I tried to follow this note (which should be in a README.fedora file):
> 
> "To use with hugin, set the 'Autopano-SIFT:' preference to
> autopano-c-complete.sh"
> 
> but I cannot make it work with hugin.

Thanks, the instructions were valid for hugin-0.7 but not for the stable hugin-0.6 in fedora.  I've updated them and created a README.fedora.

(In reply to comment #5)
> > 1. Package is not named according to guidelines:
> > autopano-sift-C-2.4-0.1.20080102svn
> 
> Ok, I've switched to the fedora naming scheme.  I've used post-release
> versioning even though there has never actually been a 2.4 release for two
> reasons:
> 
> 1. I'm merging this from my existing 3rd party repo and numbering it 2.4-0.1
> will break migration.
> 2. The formal upstream release is likely to be 2.5, so giving it a
> 'post-release' 2.4-4.1 number should be ok.

OK for using post-release versioning since we all like to have users able to upgrade from your repo. And let's really hope next upstream version will be 2.5 :)

But the versioning you used is wrong anyway. The right one for the next release should be:

autopano-sift-C-2.4-5.20080102svn

> > 7. I tried to follow this note (which should be in a README.fedora file):
> > 
> > "To use with hugin, set the 'Autopano-SIFT:' preference to
> > autopano-c-complete.sh"
> > 
> > but I cannot make it work with hugin.
> 
> Thanks, the instructions were valid for hugin-0.7 but not for the stable
> hugin-0.6 in fedora.  I've updated them and created a README.fedora.

You should really remove these instructions from the description tag. Leave them only in README.fedora. You can even use a separate source file for it if you wish (it would be easier to edit and update).

Correct these two little issues and I'll approve.

Bye,

Andrea.

(In reply to comment #6)

> OK for using post-release versioning since we all like to have users able to
> upgrade from your repo. And let's really hope next upstream version will be 2.5

It's already changed to 2.4.1 in SVN, though there is no new code, so I'm not switching to a newer snapshot for this package.

> But the versioning you used is wrong anyway. The right one for the next release
> should be:
> 
> autopano-sift-C-2.4-5.20080102svn

Ok, it's now 2.4-4.20060102svn:

http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/8/x86_64/SRPMS.panorama/autopano-sift-C-2.4-4.20080102svn.fc8.src.rpm
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/autopano-sift-C.spec

> You should really remove these instructions from the description tag. Leave
> them only in README.fedora. You can even use a separate source file for it if
> you wish (it would be easier to edit and update).

Ok, there is now a separate source file for README.fedora and I've cut the instructions from the SPEC file.

(In reply to comment #7)
>Ok, there is now a separate source file for README.fedora and I've cut the
> instructions from the SPEC file.

Just a small thing. In the following line:

cp %{SOURCE1} README.fedora

do a 'cp -a' to preserve original file attributes.

I know you won't forget to do it before committing... because this package is APPROVED!

Since RPM Fusion infrastructure is not yet completed, I wonder if you want to commit this package to Livna SVN. 

No other review process is needed. You only need to ask Thorsten to create the svn, then you will be able to import it.

Feel free to ask me (or him) if you have any problem.

Built and published in Livna.

Hi all, I've created an account (bpostle) but need to be added to the cvsextras group so I can update this to the latest release.

(In reply to comment #11)
> Hi all, I've created an account (bpostle) but need to be added to the cvsextras
> group so I can update this to the latest release.

Thorsten just approved your membership and updated the ACL too. 

Let us know if you have further problems.

Bye,

Andrea.

I get this error trying to commit to CVS:

 **** Access denied: bpostle is not in ACL for rpms/autopano-sift-C/devel

(In reply to comment #13)
> I get this error trying to commit to CVS:
> 
>  **** Access denied: bpostle is not in ACL for rpms/autopano-sift-C/devel

Please try to contact Thorsten (knurd) or Xavier (SmootherFrOgZ) on #rpmfusion in Freenode. This is the quickest way to solve the problems.

(In reply to comment #14)
> (In reply to comment #13)
> > I get this error trying to commit to CVS:
> > 
> >  **** Access denied: bpostle is not in ACL for rpms/autopano-sift-C/devel
> 
> Please try to contact Thorsten (knurd) or Xavier (SmootherFrOgZ) on #rpmfusion
> in Freenode. This is the quickest way to solve the problems.

Bruno, have you solved your problems?

Thorsten says it is done:

avail | bpostle | rpms/autopano-sift-C/F-9
avail | bpostle | rpms/autopano-sift-C/F-10
avail | bpostle | rpms/autopano-sift-C/F-11
avail | bpostle | rpms/autopano-sift-C/devel

..but I still have the same ACL problem, I can run cvs checkout,update,diff but not commit.

Package Change Request
======================
Package Name: autopano-sift-C
Updated RPMFusion Owners: bpostle

Note, I know I'm already in owners.list for this package, but I still get this error when trying to commit any CVS changes:

  Access denied: bpostle is not in ACL for rpms/autopano-sift-C/devel

Today I've tried again with a fresh-install F11 system configured for rpmfusion packaging as per the wiki and there is no change (bruno@postle.net/bpostle).

I've double checked and the cvs right are accurate on the server side,
Does the problem was solved ? (releasing cvs request).

(In reply to comment #18)
> I've double checked and the cvs right are accurate on the server side,
> Does the problem was solved ? (releasing cvs request).

Tried again with a fresh F-12 vm machine: new ssh key uploaded into the account system, downloaded a client certificate, I can `make new-sources ...` and upload the 2.5.1 tarball, but when I try to check-in the changes to CVS I get the same error:

  [bruno@honk devel]$ cvs ci -m 'Update to upstream 2.5.1'
  **** Access denied: bpostle is not in ACL for rpms/autopano-sift-C/devel
  cvs commit: Pre-commit check failed
  cvs [commit aborted]: correct above errors first!
  cvs commit: saving log message in /tmp/cvshgE3HS

Created attachment 409 [details]
Changes for update to 2.5.1 release

These are the CVS changes needed to update autopano-sift-C in rpmfusion to the current stable version.