| Summary: | Review request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Andrea Musuruane <musuruan> |
| Component: | Review Request | Assignee: | Ismael Olea <ismael> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hobbes1069, ismael, rpmfusion-package-review, zdzichu |
| Priority: | P5 | ||
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| namespace: | |||
| Bug Depends on: | |||
| Bug Blocks: | 4 | ||
|
Description
Andrea Musuruane
2011-06-21 19:03:37 CEST
mindlna.service looks fine. http://www.lesloueizeh.com/musuruan/minidlna.spec http://www.lesloueizeh.com/musuruan/minidlna-1.0.21-1.fc15.src.rpm Changelog: - Updated to upstream 1.0.21 Please note that systemd unit file (the same I made for v1.0.20) broke in this release and I cannot understand why. When I try to invoke the service it is not started. It is fine if I recall minidlna from cmd line though. (In reply to comment #2) > Please note that systemd unit file (the same I made for v1.0.20) broke in this > release and I cannot understand why. When I try to invoke the service it is not > started. It is fine if I recall minidlna from cmd line though. It might be something you mucked up on your side during development of the package. It worked fine for me without modification (from a running system, not on boot). # systemctl status minidlna.service minidlna.service - MiniDLNA is a DLNA/UPnP-AV server software Loaded: loaded (/lib/systemd/system/minidlna.service) Active: active (running) since Tue, 27 Dec 2011 13:39:29 -0600; 7s ago Process: 21626 ExecStart=/usr/sbin/minidlna -f /etc/minidlna.conf (code=exited, status=0/SUCCESS) Main PID: 21627 (minidlna) CGroup: name=systemd:/system/minidlna.service รข 21627 /usr/sbin/minidlna -f /etc/minidlna.conf Richard I'll review it. Here is my review. First, please notice there is a new 1.0.22 release at upstream. Do you plan to maintain it for EL5? If not please remove %defattr BuildRoot: %clean About funcionality, I couldn't test if it really works but I would suggest to consider to preset presentation_url to a working parameter. This is completely at your discretion. The rest of the package seems to be in very good state, including systemd scriptlets: I'm not really familiarized with systemd but seems you are following all Fedora recomendations. btw, when (re)starting the service I always got this error: Jan 15 14:46:07 patxuko systemd[1]: Failed to read PID file /var/run/minidlna.pid after start. The service might be broken. I didn't diagnose why it's really happening. (In reply to comment #5) > First, please notice there is a new 1.0.22 release at upstream. Thank you, I missed it! > Do you plan to maintain it for EL5? If not please remove > %defattr > BuildRoot: > %clean I won't maintain for EL5. I removed them. > About funcionality, I couldn't test if it really works but I would suggest to > consider to preset presentation_url to a working parameter. This is completely > at your discretion. The problem is that there is no suitable default presentation_url because the media files are usually under a user's home dir. Therefore this parameter must be edited manually. Other suggestions are appreciated :-) You can test minidlna using a DLNA DMP such as XMBC. Upnp-inspector is also available for Fedora to analyze the DLNA stack components. > The rest of the package seems to be in very good state, including systemd > scriptlets: I'm not really familiarized with systemd but seems you are > following all Fedora recomendations. I still have problems with systemd but I still have to investigate them better. I just noticed that if I comment the User and the Group lines in minidlna.service it always work. Anyway here it is an updated package. http://www.lesloueizeh.com/musuruan/minidlna.spec http://www.lesloueizeh.com/musuruan/minidlna-1.0.22-1.fc16.src.rpm Changelog: - Updated to upstream 1.0.22 - Removed default Fedora RPM features (defattr, BuildRoot, clean section) - Better consistent macro usage (In reply to comment #7) > The problem is that there is no suitable default presentation_url because the > media files are usually under a user's home dir. Therefore this parameter must > be edited manually. Other suggestions are appreciated :-) > > You can test minidlna using a DLNA DMP such as XMBC. Upnp-inspector is also > available for Fedora to analyze the DLNA stack components. Well, I'm very new to upnp/dlna and still not sure how it works (or if my LAN is mangling upnp announces) Looking through upnp-inspector I found the default URI is the same as I am specting, so now I think my comment is obvious. > I still have problems with systemd but I still have to investigate them better. > I just noticed that if I comment the User and the Group lines in > minidlna.service it always work. Maybe you should ask advice to the systemd gurus. > Anyway here it is an updated package. final checklist: +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [=] rpmlint output: shown in comment: none [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPLv2 [+] license field matches the actual license: spec credits GPLv2 [+] license file is included in %doc: COPYING [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches [+] package builds on at least one primary arch: Tested F16 x86 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [+] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [=] description and summary contains available translations [+] package builds in mock [?] package builds on all supported arches: Tested x86_64 [?] package functions as described: service is up and running, didn't test funcionality [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [+] file dependencies versus package dependencies [+] package contains man pages for binaries/scripts *** APPROVED *** Thanks for you review! Package CVS request ====================== Package Name: minidlna Short Description: Lightweight DLNA/UPnP-AV server targeted at embedded systems Owners: musuruan Branches: F-16 InitialCC: ---------------------- License tag: free Built. Closing. |