Bug 1823

I'm testing it on fedora 15 x86_64 and it works :)
Thank you

URL "http://git.xfce.org/apps/tumbler/" leads to a page that says "no repositories found". Is it supposed to be "http://git.xfce.org/xfce/tumbler/" ?

(In reply to comment #0)
> tumbler-freeworld.x86_64: E: incorrect-fsf-address
> /usr/share/doc/tumbler-freeworld-0.1.21/COPYING

Would you please file a bug upstream on this?

 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

ought to be:

 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

per http://www.gnu.org/licenses/gpl-2.0.txt

Done, see https://bugzilla.xfce.org/show_bug.cgi?id=7796

You want me to include the patch in the package, too?

(In reply to comment #3)
> You want me to include the patch in the package, too?

To be honest I don't care at all :)

If you update the URL field per my previous comment then I'll do this review.

Frankly speaking I'd prefer a complete review and then fix all issues found rather than fixing individual issues, bumping the release and rebuilding. As long as there is no severe issue that prevents testing of the package I think we should not create additional overhead. Is this ok for you?

Ok, here's my review. For reference, the original tumbler review was at https://bugzilla.redhat.com/549593


[ yes ] rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

$ rpmlint tumbler-freeworld.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint tumbler-freeworld-0.1.21-1.fc16.src.rpm 
tumbler-freeworld.src: W: spelling-error %description -l en_US thumbnailer -> thumbnail er, thumbnail-er, thumbnail
tumbler-freeworld.src: W: spelling-error %description -l en_US ffmpegthumbnailer -> thumbnail
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint /var/lib/mock/fedora-15-i386/result/tumbler-freeworld-0.1.21-1.fc15.i686.rpm 
tumbler-freeworld.i686: W: spelling-error %description -l en_US thumbnailer -> thumbnail er, thumbnail-er, thumbnail
tumbler-freeworld.i686: W: spelling-error %description -l en_US ffmpegthumbnailer -> thumbnail
tumbler-freeworld.i686: E: incorrect-fsf-address /usr/share/doc/tumbler-freeworld-0.1.21/COPYING

...nothing serious here.

[ yes ] The package must be named according to the Package Naming Guidelines .
[ yes ] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[ yes ] The package must meet the Packaging Guidelines .
[ yes ] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.

[ no  ] The License field in the package spec file must match the actual license.
Package is split between LGPL and GPL. See https://bugzilla.xfce.org/show_bug.cgi?id=6781

[ n/a ] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[ yes ] The spec file must be written in American English.
[ yes ] The spec file for the package MUST be legible.
[     ] The sources used to build the package must match the upstream source, as provided in the spec URL.

Posted SRPM: 
2ef0d30750f95efe345de4655049d4f6  tumbler-0.1.21.tar.bz2
Upstream tarball: 
2ef0d30750f95efe345de4655049d4f6  tumbler-0.1.21.tar.bz2

[ yes ] The package MUST successfully compile and build into binary rpms on at least one primary architecture.

Mocked on F15 i686.

[ n/a ] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[ yes ] All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[ n/a ] The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ n/a ] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[ yes ] Packages must NOT bundle copies of system libraries.
[ n/a ] If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[ yes ] A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[ yes ] A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[ yes ] Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[ yes ] Each package must consistently use macros.
[ yes ] The package must contain code, or permissable content.
[ n/a ] Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[ yes ] If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[ n/a ] Header files must be in a -devel package.
[ n/a ] Static libraries must be in a -static package.
[ n/a ] If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[ n/a ] In the vast majority of cases, devel packages must require the base package using a fully versioned dependency
[ n/a ] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[ n/a ] Packages containing GUI applications must include a %{name}.desktop file
[ yes ] Packages must not own files or directories already owned by other packages. 
[ yes ] All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
Items marked as SHOULD are things that the package (or reviewer) SHOULD do, but is not required to do.

[ n/a ] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. 
[ n/a ] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[ yes ] The reviewer should test that the package builds in mock.

Mocked on F15 i686.

[ yes ] The package should compile and build into binary rpms on all supported architectures.
[ yes ] The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.

Tested on F15, works well.

[ n/a ] If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[ n/a ] Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[ n/a ] The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[ n/a ] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[ n/a ] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.


My recommendations:

Please change the URL to be http://git.xfce.org/xfce/tumbler/ , and in the tumbler package in Fedora as well.

Please change the License field to indicate both LGPLv2 and GPLv2. (Looks like you brought this up in the initial tumbler review request :)

APPROVED