Bug 2162

Summary: Upgrade lame to 3.99.4
Product: Fedora Reporter: Göran Uddeborg <goeran>
Component: lameAssignee: Dominik 'Rathann' Mierzejewski <dominik>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P5    
Version: 17   
Hardware: All   
OS: GNU/Linux   
namespace:
Attachments: Patches to move lame to the most recent version at the time of writing
Here is the rpmsodiff output between lame-libs-3.98.4-1.fc14.x86_64 and a fresh built/lame-libs-3.99.4-1.fc18.x86_64 in the devel branch with your (kwizart's) changes from February 19.

Description Göran Uddeborg 2012-01-30 17:39:53 CET
Created attachment 792 [details]
Patches to move lame to the most recent version at the time of writing

I saw in rpmfusion-devel a comaintainer is desired for the package lame.  I took a look at it and attach diffs to upgrade lame to 3.99.4.  I could help in comaintaining the package if you like.
Comment 1 Göran Uddeborg 2012-01-30 17:55:51 CET
By the way, rpmlint complains about the address in the COPYING file.  I've filed a report about that.

https://sourceforge.net/tracker/?func=detail&aid=3481701&group_id=290&atid=100290
Comment 2 Nicolas Chauvet 2012-04-09 19:03:59 CEST
Can you attach an output of rpmsodiff between the two lame ? (current / yours)

We might need to rebuild every package using lame to fix the silent ABI break.


Here is a list of packages directly using lame-libs to be rebuilt
avidemux-2.5.6-6.fc17.src.rpm
ffmpeg-0.10.2-1.fc17.src.rpm
gstreamer-plugins-ugly-0.10.18-7.fc17.src.rpm
k3b-extras-freeworld-2.0.2-6.fc17.src.rpm
libquicktime-1.2.3-6.fc17.src.rpm
mplayer-1.0-0.129.20110816svn.fc17.src.rpm
mpd-0.16.7-2.fc17.src.rpm
mythtv-0.24.2-2.fc17.src.rpm
swftools-0.9.1-6.fc17.src.rpm
sox-plugins-freeworld-14.3.2-3.fc17.src.rpm
swftools-0.9.1-6.fc17.src.rpm
transcode-1.1.7-4.fc17.src.rpm
traverso-0.49.2-2.fc14.src.rpm
Comment 3 Nicolas Chauvet 2012-04-09 19:04:38 CEST
(that would worth to test rebuilt them with the new lame).

Thx for your work
Comment 4 Göran Uddeborg 2012-04-09 22:25:10 CEST
Created attachment 852 [details]
Here is the rpmsodiff output between lame-libs-3.98.4-1.fc14.x86_64 and a fresh built/lame-libs-3.99.4-1.fc18.x86_64 in the devel branch with your (kwizart's) changes from  February 19.

Looking a bit closer, none of the removed symbols are mentioned in the API file, nor in the lame.h file from lame-devel-3.98.4.  So this might not be any ABI break at all.  Not of the PUBLIC ABI, that is.  And any normal program that used the header file to define the symbols won't have any references.  So chances are pretty good that it would be ok to replace, without any rebuild of dependent packages.

Is the way to check for sure to download each of them and investigate any binaries with "nm"?  Or is there some other fancy tool I have missed? :-)
Comment 5 Nicolas Chauvet 2012-05-01 15:35:47 CEST
Actually I've handled it earlier on devel and backported the Matthias update.
But it will be valuable to have a primary maintainer for the package. Can you make an ACL request for it ?

>Is the way to check for sure to download each of them and investigate any
>binaries with "nm"?  Or is there some other fancy tool I have missed? :-)
I'm only using rpmlint on installed package for a higher level tool.
This might discover missing symbols from dependencies.

Some package are known to use private symbol such as mplayer with ffmpeg (that's why it need to be rebuilt on each ffmpeg update). I wouldn't too surprised that some lame dependencies do the same.
Comment 6 Göran Uddeborg 2012-05-01 17:09:55 CEST
Yes, my offer to maintain is still valid,  You say "primary maintainer" which I guess means there is no maintainer at all right now.  (I'm not sure how to find out who the maintainer for a package is.)

Package Change Request
======================
Package Name: lame
Updated RPMFusion Owners: goeran
Comment 7 Göran Uddeborg 2012-05-05 23:04:13 CEST
Thank you.

The original purpose of this bugzilla, to upgrade to 3.99.4, is no longer relevant.  But I'll ask my web secretary to keep an eye open for future upstreams changes, and will keep the Fusion package updated.