Bug 2227

Summary:	RFE: build an alternate x264 for 10bit option
Product:	Fedora	Reporter:	Nicolas Chauvet <kwizart>
Component:	x264	Assignee:	Sérgio Basto <sergio>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kwizart, sergio
Priority:	P5
Version:	17
Hardware:	All
OS:	GNU/Linux
namespace:

Description Nicolas Chauvet 2012-03-13 16:06:08 CET

x264 has gained support with 10bit encoding.
But this is currently a build time option that are incompatible with 8bit. The next vlc will expect an usual x264 to provides 8bit and a special x26410b to provides 10bit encoding.

I don't think it worth to make a different package based on the same snapshot.
But the jobs would be to do a second build (same as done with ffmpeg) with
another SONAME for the 10bit option.

There will probably be a need to patch the x264 buildsys to achieve that.
Unless the encoding length can be made selectable at runtime, we may need to handle the case that way.

This option exists at least on current x264 from F-17.

Comment 1 Sérgio Basto 2012-05-27 14:13:58 CEST

Nicolas Chauvet wrote:
> > Also, x264 has gained support with 10bit encoding.
> > But this is currently a build time option that are incompatible.
> > vlc will expect x264.so to provides 8bit and x26410b.so to provides 10bit.
> > 
> > I don't think it worth to make a different package based on the same snapshot.
> > But could you look into doing a second build (same as done with ffmpeg) with
> > another SONAME for the 10bit option ?
> > 
> > You will probably have to patch the x264 buildsys to acheive that.

> ./configure
>   --bit-depth=BIT_DEPTH    set output bit depth (8-10) [8]
> 
> > rpm -qp results/x264-libs-0.120-2.20120303.fc17.x86_64.rpm -l
> > /usr/lib64/libx264.so.120
> > just have one .so 
> That's the point, you would have to make it.
> But this can be a second step. I can submit a RFE.

Comment 2 Kevin Kofler 2012-06-15 02:33:50 CEST

Do the 2 builds actually end up exporting differently-named symbols? If not, trying to use them in the same executable at the same time is a guaranteed symbol conflict and thus a crash waiting to happen.

Comment 3 Sérgio Basto 2012-06-17 05:39:23 CEST

Add one build with --bit-depth=10 and just install /usr/lib(64)/libx26410b.so.124 
and /usr/lib(64)/libx26410b.so (devel package). 
Since it is harmless, I built it in rawhide. 

the patch applied to spec:
http://cvs.rpmfusion.org/viewvc/rpms/x264/devel/x264.spec?root=free&r1=1.36&r2=1.38&view=patch

Comment 4 Sérgio Basto 2012-08-06 20:02:32 CEST

spec was modified by Nicolas Chauvet and me. 
VLC already use 10bit option ? 
may I close this report ? 

Thanks,