| Summary: | Rename VirtualBox-OSE to VirtualBox | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Sérgio Basto <sergio> |
| Component: | Review Request | Assignee: | RPM Fusion Package Review <rpmfusion-package-review> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexjnewt, emmanuel, fedora, naveed, rpmfusion-package-review |
| Priority: | P5 | ||
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| namespace: | |||
| Attachments: |
current patch to rename VirtualBox
current patch to rename VirtualBox-kmod |
||
|
Description
Sérgio Basto
2012-04-30 06:53:55 CEST
where I put review for VirtaulBox-kmod ? here in same review or open another review ? Small detail from a cursory look at the spec file: Should we remove -OSE- from the Source# and Patch# file names in this process as well? (In reply to comment #2) > Small detail from a cursory look at the spec file: Should we remove -OSE- from > the Source# and Patch# file names in this process as well? yes I will do on one second step, for now is much more simple use same sources and same patches names. I plan do only branches on F17 and devel, therefore F16 will still VirtualBox-OSE, and if we need update it, we have all the same files which will be much more simple, once I know that F15 and F16 don't need updates I will rename all. Spec URL: http://www.serjux.com/virtualbox/VirtualBox.spec SRPM URL: http://www.serjux.com/virtualbox/VirtualBox-4.1.14-4.fc16.src.rpm and Spec URL: http://www.serjux.com/virtualbox/VirtualBox-kmod.spec SRPM URL: http://www.serjux.com/virtualbox/VirtualBox-kmod-4.1.14-2.fc16.src.rpm Plan summary: 1st - keep same maintainers in new branches, they have done a wonderful job and they may help . 2nd - Only do branches for F17 and devel. http://www.serjux.com/virtualbox/17/ have testing rpms. 3st - in a second step rename all patches and sources , after retirement of -OSE. Sorry, why not use kmod-VirtualBox instead VirtualBox-kmod? A lot of users know kmod-xxxxxx packages so should be easiest to remember kmod-VirtualBox, for users... (In reply to comment #5) > Sorry, why not use kmod-VirtualBox instead VirtualBox-kmod? A lot of users know This is internal kitchen. users still have to use kmod-VirtualBox or kmod-VirtualBox-PAE Thank you :) Hi, I'd like do this before F17 release, F17 should be out in the end of the month. Or decide what to do with bug 1826 ? , close with won't fix or close with fixed when we close this review. (In reply to comment #8) > Hi, I'd like do this before F17 release, F17 should be out in the end of the > month. In support of Sérgio, some examples of Red Hat rename package review requests - https://bugzilla.redhat.com/show_bug.cgi?id=596866 https://bugzilla.redhat.com/show_bug.cgi?id=476483 https://bugzilla.redhat.com/show_bug.cgi?id=236652 They're generally quick and painless. Created attachment 872 [details]
current patch to rename VirtualBox
Created attachment 873 [details]
current patch to rename VirtualBox-kmod
Hi, here is the state of art to rename VirtualBox.
Please import the renamed -kmod (Makefile should be fixed). Now I have the same problem with VirtualBox-kmod cvs co VirtualBox-kmod cvs server: cannot find module `VirtualBox-kmod' - ignored please talk in chat ... (In reply to comment #13) > Now I have the same problem with VirtualBox-kmod > > cvs co VirtualBox-kmod > cvs server: cannot find module `VirtualBox-kmod' - ignored > > please talk in chat ... Out for tonight, but please make a fresh checkout the -kmod is expected to work. I Have made the change for VirtualBox, you only have to make the VirtualBox-kmod. The kmod rebuilt script has escaped the VirtualBox-kmod case for F-16. (In reply to comment #12) > Please import the renamed -kmod (Makefile should be fixed). all fixed and all done Confirmed on a test machine running f17 PAE kernel. We need update bugzilla components Done. |