Bug 2473

No time for a real review right now, but just a quick comment: I think you forgot ext/xvid in extdirs (which adds xvidcore-devel as a BuildRequires)

Also, you should probably use %global rather than %define.

I'll try to get some time to do a real review soon, but I certainly won't mind if someone beats me to it. :)

Hi,

(In reply to comment #1)
> No time for a real review right now, but just a quick comment: I think you
> forgot ext/xvid in extdirs (which adds xvidcore-devel as a BuildRequires)

No, that was removed compared to the 0.10 package on purpose as it has not yet been ported to the new 1.0 API.

> Also, you should probably use %global rather than %define.

Fixed.

Here is a new version (which also rebases to the the new upstream 0.11.99 release:

Spec: http://jwrdegoede.danny.cz/gstreamer1-plugins-bad-freeworld.spec
SRPM:
http://jwrdegoede.danny.cz/gstreamer1-plugins-bad-freeworld-0.11.99-1.fc19.src.rpm

Here are new versions of the package rebased to the latest 1.0.2 upstream release:
Spec: http://jwrdegoede.danny.cz/gstreamer1-plugins-bad-freeworld.spec
SRPM: http://jwrdegoede.danny.cz/gstreamer1-plugins-bad-freeworld-1.0.2-1.fc19.src.rpm

I'll review this.

Here is the review:

 +:ok, =:needs attention, -:needs fixing

MUST Items:
[-] MUST: rpmlint must be run on every package.
$ rpmlint *.rpm
gstreamer1-plugins-bad-freeworld.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-freeworld.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-freeworld.src:90: W: macro-in-comment %{_libdir}
gstreamer1-plugins-bad-freeworld.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-freeworld.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-freeworld-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package gstreamer1-plugins-bad-freeworld.
gstreamer1-plugins-bad-freeworld-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gst-plugins-bad-1.0.2/gst/dvbsuboverlay/gstdvbsuboverlay.h
3 packages and 0 specfiles checked; 2 errors, 5 warnings.
[+] MUST: The package must be named according to the Package Naming Guidelines.
It matches Fedora name not the upstream tarball.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
LGPLv2+
[-] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL.
md5sum gst-plugins-bad-1.0.2.tar.xz
17f2ba1b51347061f8f81436d6c7b65e  gst-plugins-bad-1.0.2.tar.xz
md5sum ../SOURCES/gst-plugins-bad-1.0.2.tar.xz 
17f2ba1b51347061f8f81436d6c7b65e  ../SOURCES/gst-plugins-bad-1.0.2.tar.xz
[+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture.
Tested with Fedora-18/x86_64
[+] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines.
Fine. It's for RPM Fusion.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability).
[+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
[+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.
[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
Tested with Fedora-18/x86_64
[+] SHOULD: The reviewer should test that the package functions as described.
I don't have access to a Fedora 18 therefore I cannot test it
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[+] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[+] SHOULD: Packages should try to preserve timestamps of original installed files.


Issues:
1. You should report upstream that an incorrect FSF address is been used in /usr/src/debug/gst-plugins-bad-1.0.2/gst/dvbsuboverlay/gstdvbsuboverlay.h

2. The following files are missing in %doc: COPYING.LIB, NEWS, RELEASE. REQUIREMENTS must not be included because it is not relevant. COPYING must not be included because the software is all licensed under LGPLv2+ and not GPLv2.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Documentation


I'll trust you'll do these before importing in RPM Fusion.

APPROVED!

(In reply to comment #5)
> Here is the review:
> 

Thanks!

> Issues:
>
> 1. You should report upstream that an incorrect FSF address is been used in
> /usr/src/debug/gst-plugins-bad-1.0.2/gst/dvbsuboverlay/gstdvbsuboverlay.h

Reported here:
https://bugzilla.gnome.org/show_bug.cgi?id=687520

> 
> 2. The following files are missing in %doc: COPYING.LIB, NEWS, RELEASE.
> REQUIREMENTS must not be included because it is not relevant. COPYING must not
> be included because the software is all licensed under LGPLv2+ and not GPLv2.
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Documentation

Will fix before import.

> APPROVED!

Thanks!

Package CVS request
======================
Package Name: gstreamer1-plugins-bad-freeworld
Short Description: GStreamer 1.0 streaming media framework "bad" plug-ins
Owners: jwrdegoede
Branches: F-18
InitialCC:
----------------------
License tag: free

Imported and build, thanks to all involved for the help !!