| Summary: | Review request:librcd - Russian Encoding Detection Library | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | A. Trande (sagitter) <trpost> |
| Component: | Review Request | Assignee: | RPM Fusion Package Review <rpmfusion-package-review> |
| Status: | RESOLVED INVALID | ||
| Severity: | normal | CC: | musuruan, rpmfusion-package-review, trpost |
| Priority: | P5 | ||
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| namespace: | |||
| Bug Depends on: | |||
| Bug Blocks: | 30, 2528 | ||
|
Description
A. Trande (sagitter)
2012-10-13 18:33:43 CEST
Can you please state why this package is not eligible for Fedora? If NEWS file is empty there is no need to include it. Do not use %makeinstall macro: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Buildroot, clean section and defattr are no longer required: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions These lines are not required or necessary: Prefix: %{_prefix} Docdir: %{_docdir} Changelog should reflect RPM changes but now it's empty. Release number must start from 1: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag (In reply to comment #1) > Can you please state why this package is not eligible for Fedora? > I don't open a review request for Fedora to keep librcd/librcc and MOC on the same repositories. Moreover librcd/librcc are libraries with a limited use. I think that it was the right choice. (In reply to comment #1) > If NEWS file is empty there is no need to include it. > > Do not use %makeinstall macro: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used > > Buildroot, clean section and defattr are no longer required: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions > > These lines are not required or necessary: > Prefix: %{_prefix} > Docdir: %{_docdir} > > Changelog should reflect RPM changes but now it's empty. > > Release number must start from 1: > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag http://sagitter.fedorapeople.org/librcd.spec http://sagitter.fedorapeople.org/librcd-0.1.13-1.fc17.src.rpm $ rpmlint librcd-0.1.13-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint librcd-0.1.13-1.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks. (In reply to comment #2) > (In reply to comment #1) > > Can you please state why this package is not eligible for Fedora? > > > I don't open a review request for Fedora to keep librcd/librcc and MOC on the > same repositories. Moreover librcd/librcc are libraries with a limited use. I > think that it was the right choice. I'm sorry but we do not accept packages that can go in Fedora. RPM Fusion ships only packages that cannot be included in Fedora. Please close this review request and open it in Fedora (and do the same for librcc). (In reply to comment #4) > (In reply to comment #2) > > (In reply to comment #1) > > > Can you please state why this package is not eligible for Fedora? > > > > > I don't open a review request for Fedora to keep librcd/librcc and MOC on the > > same repositories. Moreover librcd/librcc are libraries with a limited use. I > > think that it was the right choice. > > I'm sorry but we do not accept packages that can go in Fedora. RPM Fusion ships > only packages that cannot be included in Fedora. Please close this review > request and open it in Fedora (and do the same for librcc). Considering that libRCC/libRCD are not essential libraries to manage MOC, I will remove them as dependences. In this moment I'm interested to include MOC on RPM Fusion. :) Thank you. |