Bug 2687

Summary:	fg: no job control - error message on update
Product:	Fedora	Reporter:	dssink
Component:	openafs	Assignee:	Ken Dreyer <ktdreyer>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jjneely, ktdreyer
Priority:	P5
Version:	17
Hardware:	i386
OS:	GNU/Linux
namespace:
Bug Depends on:	2692
Bug Blocks:

Description dssink 2013-02-18 18:42:48 CET

When updating to openafs-client-1.6.2-1.fc17.i686 I got what appears to amount to a warning: 

/var/tmp/rpm-tmp.fYHrhf: line 1: fg: no job control

The update completes as expected, so it's not a full stop error. If I can provide more info please let me know what you'd like.

Comment 1 Ken Dreyer 2013-02-18 21:45:44 CET

I wonder if the problem lies here:

276 %post client
277 %if !0%{?_with_systemd}
278   %systemd_post openafs-client.service
279 %endif


My hunch is that we have accidentally inverted the conditional, or that %systemd_post is missing on Fedora 17, or maybe a combination of both.

Comment 2 Ken Dreyer 2013-02-18 23:42:38 CET

Yeah, I'm thinking that the condition should be inverted (remove the "!"), and that should fix things.

It also looks like the %systemd_post macro is unavailable on Fedora 17 [1]. This is not a big deal in OpenAFS's case, since we didn't enable _with_systemd until Fedora 18. That's probably what is causing %post script to print an "fg" error.

Jack, if you could check my reasoning here, I'll commit and push the fix (should just be a single change to remove the "!" character). Or dssink, if you want to rebuild the RPM with that adjustment and test, that would be good too :)

[1] https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

Comment 3 Jack Neely 2013-02-21 18:40:24 CET

Ken, I agree.  Let's remove the "!" character and push out those changes.

Comment 4 Ken Dreyer 2013-02-21 20:37:30 CET

I'm testing some local mock builds here and I'll push an update to fix this later today.

Comment 5 Ken Dreyer 2013-02-21 22:19:41 CET

There's a problem with the build infrastructure right now, which I've filed as bug 2692. When that's resolved we should be able to build -2, which contains the fix.

Comment 6 Ken Dreyer 2013-03-04 22:17:02 CET

openafs-1.6.2-2.fc17 has reached the stable repo, so I'm closing this bug. Feel free to re-open if the problem continue.