Bug 2761

Summary: nvidia-304xx-kmod - NVIDIA 304xx display driver kernel module
Product: Package Reviews Reporter: Nicolas Chauvet <kwizart>
Component: Review RequestAssignee: RPM Fusion Package Review <rpmfusion-package-review>
Status: RESOLVED FIXED    
Severity: normal CC: leigh123linux, rpmfusion-package-review, sergio
Priority: P5    
Version: Current   
Hardware: All   
OS: GNU/Linux   
namespace:
Bug Depends on:    
Bug Blocks: 4    

Comment 1 leigh scott 2013-05-18 15:46:16 CEST
Please add a changelog when you import


$ rpmlint '/home/leigh/Desktop/nvidia-304xx-kmod-304.88-0.fc17.src.rpm' 
nvidia-304xx-kmod.src: W: unexpanded-macro %description -l C %{kversion}
nvidia-304xx-kmod.src: W: spelling-error %description -l en_US kversion -> version, aversion, k version
nvidia-304xx-kmod.src: E: no-changelogname-tag
nvidia-304xx-kmod.src:17: W: macro-in-comment %{version}
nvidia-304xx-kmod.src:17: W: macro-in-comment %{version}
nvidia-304xx-kmod.src:18: W: macro-in-comment %{version}
nvidia-304xx-kmod.src:18: W: macro-in-comment %{version}
nvidia-304xx-kmod.src: W: invalid-url Source0: nvidia-kmod-data-304.88.tar.xz
1 packages and 0 specfiles checked; 1 errors, 7 warnings.

Also shouldn't the expanded macro be removed (%{kversion})?
Apart from that the package meets the review guidelines.

PACKAGE APPROVED.
Comment 2 Nicolas Chauvet 2013-05-19 12:46:46 CEST
Package CVS request
======================
Package Name: nvidia-304xx-kmod
Short Description: NVIDIA 304xx display driver kernel module
Owners: kwizart
Branches: F-17 F-18 F-19
InitialCC: sergiomb,leigh123linux
----------------------
License tag: nonfree