Bug 2804

Summary:	Review Request: jvgs - Minimalistic platform game loosely based on xkcd webcomic
Product:	Package Reviews	Reporter:	pcpa <paulo.cesar.pereira.de.andrade>
Component:	Review Request	Assignee:	Björn "besser82" Esser <bjoern.esser>
Status:	RESOLVED EXPIRED
Severity:	normal	CC:	bjoern.esser, rpmfusion-package-review
Priority:	P5
Version:	Current
Hardware:	All
OS:	GNU/Linux
namespace:	nonfree
Attachments:	mock-build fails on rawhide jvgs-lua52.patch

Description pcpa 2013-05-18 16:28:52 CEST

Spec URL: http://pcpa.fedorapeople.org/jvgs.spec
SRPM URL: http://pcpa.fedorapeople.org/jvgs-0.5.1-1.fc20.src.rpm
Description: This game takes place in a world much like ours, which has started
fading away. At a point where nearly everything has gone, a poet
finds himself, alone in a strange world of danger. He starts a journey
along the broken stream of thoughts that's left.

The package is not eligible for fedora because the sound track is
Creative Commons Attribution Non-Commercial Share Alike license;
The Non-Commercial is the problem. It works if stripping the sound
from the installation, but I believe that removes most of the
game experience, and requiring the user to download the sound track
is too much overhead for the user also giving the user could just
enable rpmfusion for other similar content.

Last run of fedora-review on it can be found at:
https://bugzilla.redhat.com/show_bug.cgi?id=914798#c3

This is still my first attempt of getting a package in rpmfusion.
Previously I cancelled 0ad and nvidia-texture-tools requests
because it ended up being approved for Fedora; some of my first
Fedora contributions...

Comment 1 Björn "besser82" Esser 2013-06-08 14:25:18 CEST

I'll take this one.

Comment 2 Björn "besser82" Esser 2013-06-08 14:33:42 CEST

Created attachment 1119 [details]
mock-build fails on rawhide

Build fails on rawhide, logs attached.

Comment 3 pcpa 2013-06-08 18:58:55 CEST

Created attachment 1120 [details]
jvgs-lua52.patch

  I just posted this patch to upstream author, but only to inform him
there are problems with lua 5.2 and jvgs.
  I had already bothered him with license issues, and at the end it was
not allowed in Fedora due to CC-BYSA no commercial use of the sound
track...
  The patch only corrects the build, but there are runtime errors,
that I started fixing, but they started cascading errors, so I preferred
to not add any hack in the patch, with the patch, after build it fails
like this:

$ jvgs
Message - FPS: 360.917236
Message - FPS: 360.279449
Message - FPS: 414.585419
Message - FPS: 428.571442
Message - FPS: 391.608398
Message - FPS: 366.899292
Message - FPS: 305.084747
Error - resources/common-scripts/enemy.lua: ./resources/modules/common.lua:9: attempt to compare nil with number

Comment 4 Björn "besser82" Esser 2013-06-09 07:08:58 CEST

Thanks for your quick replay.

In this case, I think, we should wait 'til upstream will have these issues fixed.  Just drop in an updated pkg when upstream is ready and I'll take care of it then.