Bug 3688

Summary: Review request: vdr-mpv - A mpv player plugin for VDR
Product: Package Reviews Reporter: MartinKG <mgansser>
Component: Review RequestAssignee: RPM Fusion Package Review <rpmfusion-package-review>
Status: RESOLVED FIXED    
Severity: normal CC: rpmfusion-package-review, sergio
Priority: P5    
Version: Current   
Hardware: All   
OS: GNU/Linux   
namespace:
Bug Depends on:    
Bug Blocks: 4    

Description MartinKG 2015-06-11 19:04:04 CEST 
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-mpv.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-mpv-0.0.2-1.fc22.src.rpm

Description:A mpv player plugin for VDR forked from vdr-play

Fedora Account System Username: martinkg

this package belongs to rpmfusion, due mpv dependencies.

# rpmlint vdr-mpv-0.0.2-1.fc22.x86_64.rpm
vdr-mpv.x86_64: W: invalid-url URL: http://projects.vdr-developer.org/projects/plg-mpv HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

# rpmlint vdr-mpv-debuginfo-0.0.2-1.fc22.x86_64.rpm
vdr-mpv-debuginfo.x86_64: W: invalid-url URL: http://projects.vdr-developer.org/projects/plg-mpv HTTP Error 404: Not Found
vdr-mpv-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/mpv-0.0.2/player.h
vdr-mpv-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/mpv-0.0.2/mpv.cpp
vdr-mpv-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/mpv-0.0.2/player.c
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

# rpmlint vdr-mpv-0.0.2-1.fc22.src.rpm
vdr-mpv.src: W: invalid-url URL: http://projects.vdr-developer.org/projects/plg-mpv HTTP Error 404: Not Found
vdr-mpv.src: W: invalid-url Source0: vdr-mpv-0.0.2.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

%changelog
* Tue Jun 09 2015 Martin Gansser <martinkg@fedoraproject.org> - 0.0.2-1
- initial build
Comment 1 MartinKG 2015-06-30 20:54:16 CEST 
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-mpv.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-mpv-0.0.4-1.fc22.src.rpm

%changelog
* Tue Jun 30 2015 Martin Gansser <martinkg@fedoraproject.org> - 0.0.4-1
- Update to 0.0.4
Comment 2 Sérgio Basto 2015-07-06 21:12:58 CEST 
As Martin mention it is a small program... 

package review 
 0 errors, 0 warnings. 

Only question that I have is: why we need added -fPIC in %build ? 

%build
make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags} all

Package APPROVED
Comment 3 MartinKG 2015-07-06 21:33:19 CEST 
(In reply to comment #2)
> As Martin mention it is a small program... 
> 
> package review 
>  0 errors, 0 warnings. 
> 
> Only question that I have is: why we need added -fPIC in %build ? 
> 
> %build
> make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags}
> all
> 
> Package APPROVED

compilation fails without -fPIC

g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -shared mpv.o config.o control.o filebrowser.o osd.o player.o playmenu.o setup.o status.o -lXrandr  -lmpv  -o libvdr-mpv.so
/usr/bin/ld: mpv.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
Comment 4 MartinKG 2015-07-06 21:35:44 CEST 
@Sergio, thanks for your help

Package CVS request
======================
Package Name: vdr-mpv
Short Description: A mpv player plugin for VDR
Owners: martinkg
Branches: f21 f22
InitialCC:
----------------------
License tag: free
Comment 5 MartinKG 2016-07-09 00:14:36 CEST 
imported and build of the package was successfully for f24 and rawhide.
Comment 6 MartinKG 2016-07-14 15:26:10 CEST 
The import and build have been done correctly.