Bug 3912

Summary: Review request: lives - Video editor and VJ tool
Product: Package Reviews Reporter: A. Trande (sagitter) <trpost>
Component: Review RequestAssignee: Sérgio Basto <sergio>
Status: RESOLVED FIXED    
Severity: normal CC: dmantipov, rpmfusion-package-review, salsaman, sergio, susi.lehtola, trpost, vascom2, vienna550
Priority: P5    
Version: Current   
Hardware: All   
OS: GNU/Linux   
namespace:
Bug Depends on: 3911    
Bug Blocks: 4    
Attachments: lives.dmitry.spec
LiVES.appdata.xml

Description A. Trande (sagitter) 2015-12-20 16:09:18 CET
SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-1.fc23.src.rpm

Description:
LiVES began in 2002 as the Linux Video Editing System.
Since it now runs on more operating systems: LiVES is a Video Editing System.
It is designed to be simple to use, yet powerful.
It is small in size, yet it has many advanced features.

It's not eligible in Fedora because requires 'ffmpeg' and other packages outside Fedora repos.

Note:

I seen previous request (https://bugzilla.rpmfusion.org/show_bug.cgi?id=1936), I have chose to install 'libweed' as private library in /usr/lib/lives because it's used only by LiVES, and also distributed in LiVES's source archive only.

/usr/lib/lives directory also cointains 'weed' header files.

'Exec' key in the .desktop file is changed in order to point the LIBRARY_PATH to new location of private libraries.

src package provides an appdata file.

frei0r.so library seems missing, I can't find it in Fedora so 'frei0r' support is disabled yet.

Still unavailable some libraries like faad2 and libdca (and others) in RPMFusion Free for Fedora 23, therefore some Requires packages (mencoder, mplayer) cannot be installed together with LiVES.
Comment 1 Sérgio Basto 2015-12-21 07:55:40 CET
did you check bug #1936 ?
Comment 2 A. Trande (sagitter) 2015-12-21 10:01:43 CET
(In reply to comment #1)
> did you check bug #1936 ?

Yes; why?
Comment 3 A. Trande (sagitter) 2015-12-21 12:22:46 CET
SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-2.fc23.src.rpm

- License fixed
- frei0r support enabled
Comment 4 A. Trande (sagitter) 2015-12-21 12:29:01 CET
(In reply to comment #2)
> (In reply to comment #1)
> > did you check bug #1936 ?
> 
> Yes; why?

I had not seen bg#1936 was still opened althought it's 4 years old.
Comment 5 Sérgio Basto 2015-12-21 15:40:45 CET
(In reply to comment #4)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > did you check bug #1936 ?
> > 
> > Yes; why?

Sorry I hadn't read your comment #0,  I just want that you based your spec in the others available, but I haven't check .

> I had not seen bg#1936 was still opened althought it's 4 years old.

https://fedoraproject.org/wiki/Policy_for_stalled_package_review
Comment 6 A. Trande (sagitter) 2015-12-21 15:55:24 CET
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > did you check bug #1936 ?
> > > 
> > > Yes; why?
> 
> Sorry I hadn't read your comment #0,  I just want that you based your spec in
> the others available, but I haven't check.

How? Do you mean that I should split LiVES in sub-packages? 

> 
> > I had not seen bg#1936 was still opened althought it's 4 years old.
> 
> https://fedoraproject.org/wiki/Policy_for_stalled_package_review

Latest comment (https://bugzilla.rpmfusion.org/show_bug.cgi?id=1936#c17) was written on January,3rd 2012.

Is not sufficiently stalled? :)
However, I commented again.
Comment 7 Sérgio Basto 2015-12-21 16:08:56 CET
*** Bug 1936 has been marked as a duplicate of this bug. ***
Comment 8 Sérgio Basto 2015-12-21 16:10:43 CET
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #2)
> > > > (In reply to comment #1)
> > > > > did you check bug #1936 ?
> > > > 
> > > > Yes; why?
> > 
> > Sorry I hadn't read your comment #0,  I just want that you based your spec in
> > the others available, but I haven't check.
> 
> How? Do you mean that I should split LiVES in sub-packages? 

When I wrote at first time, I just want be sure that you are aware of the other review. 
I will check the second question ;) 

> > 
> > > I had not seen bg#1936 was still opened althought it's 4 years old.
> > 
> > https://fedoraproject.org/wiki/Policy_for_stalled_package_review
> 
> Latest comment (https://bugzilla.rpmfusion.org/show_bug.cgi?id=1936#c17) was
> written on January,3rd 2012.
> 
> Is not sufficiently stalled? :)
> However, I commented again.

You need to close it as duplicated as this bug .
Comment 9 salsaman 2015-12-21 18:08:06 CET
In case it is missed from the duplicate:

Minimal set of dependencies (for ubuntu...) is currently:

mplayer / mplayer2 imageMagick sox perl libpulse-dev (libavcodec-dev
libavformat-dev libavutil-dev libswscale-dev) OR (ffmpeg_libs) mjpegtools
libogg-dev libtheora-dev libtheora-bin libvorbis-dev libunicap2-dev
libgl1-mesa-dev glee-dev libglu1-mesa-dev libjack-dev OR libjack-jackd2-dev
libdv4-dev libraw1394-dev libavc1394-dev python


Optional: libfftw3-dev, libopencv-dev, ladspa-sdk, frei0r-plugins-dev,
libvisual-0.4-dev, libsdl1-2.dev, theora-bin, mkvtoolnix, vorbis-tools,
libmatroska, ogmtools, dvgrab, frei0r-plugins,
libdv2-apps/libdv-bin, cdda2wav/icedax, lame, ffmpeg, x264, youtube-dl, LADSPA
plugins

Please adapt this for RPMFusion.

- salsaman (main developer of LiVES).
Comment 10 A. Trande (sagitter) 2015-12-21 19:39:09 CET

(In reply to comment #9)
> In case it is missed from the duplicate:
> 
> Minimal set of dependencies (for ubuntu...) is currently:
> 
> mplayer / mplayer2 imageMagick sox perl libpulse-dev (libavcodec-dev
> libavformat-dev libavutil-dev libswscale-dev) OR (ffmpeg_libs) mjpegtools
> libogg-dev libtheora-dev libtheora-bin libvorbis-dev libunicap2-dev
> libgl1-mesa-dev glee-dev libglu1-mesa-dev libjack-dev OR libjack-jackd2-dev
> libdv4-dev libraw1394-dev libavc1394-dev python
> 
> 
> Optional: libfftw3-dev, libopencv-dev, ladspa-sdk, frei0r-plugins-dev,
> libvisual-0.4-dev, libsdl1-2.dev, theora-bin, mkvtoolnix, vorbis-tools,
> libmatroska, ogmtools, dvgrab, frei0r-plugins,
> libdv2-apps/libdv-bin, cdda2wav/icedax, lame, ffmpeg, x264, youtube-dl, LADSPA
> plugins
> 
> Please adapt this for RPMFusion.
> 
> - salsaman (main developer of LiVES).

Thanks.

SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-3.fc23.src.rpm

- List BRequires and Requires packages completed
- Weed's devel files removed
Comment 11 salsaman 2015-12-21 19:55:32 CET
Thanks. Not sure if you need python-devel, it's the python binary which is recommended. Also if you have projectM in RPMFusion, you could include projectM-devel / projectM plugins for extra fun.
Comment 12 Sérgio Basto 2015-12-23 04:14:46 CET
(In reply to comment #11)
> Thanks. Not sure if you need python-devel, it's the python binary which is
> recommended. Also if you have projectM in RPMFusion, you could include
> projectM-devel / projectM plugins for extra fun.

Salsaman adding projectM break builds which ends with error: 

In file included from projectM.cpp:42:0:
/usr/include/libprojectM/projectM.hpp: In function 'void* worker(void*)':
/usr/include/libprojectM/projectM.hpp:284:8: error: 'void projectM::selectRandom(bool)' is private
   void selectRandom(const bool);
        ^
projectM.cpp:291:50: error: within this context
       if (rerand) sd->globalPM->selectRandom(true);


Antonio, please use bzip2-devel, F22 don't have pkgconfig(bzip2) !?
-BuildRequires:  pkgconfig(bzip2)
+BuildRequires:  bzip2-devel

Comment libprojectM

-BuildRequires:  pkgconfig(libprojectM)
+#BuildRequires:  pkgconfig(libprojectM)

and add mjpegtools
+BuildRequires:  pkgconfig(mjpegtools)

Best regards
Comment 13 Susi Lehtola 2015-12-23 07:16:15 CET
Please drop the spurious "is a" from the summary. Instead of

Summary:        LiVES is a Video Editing System

it should be just

Summary:        A video editing system
Comment 14 salsaman 2015-12-23 07:30:35 CET
Well, "LiVES is a Video Editing System" is an explanation of the acronym. If you want to change it to a summary then perhaps either "A video editor and VJ tool" or "A video editor, VJ tool and video programming environment" would be a better description.

Regarding projectM, you will need a version more recent than 29/08/2011. So either that package should be updated, or you should skip it.
Comment 15 A. Trande (sagitter) 2015-12-23 15:01:26 CET
SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-4.fc23.src.rpm

- libprojectM-2.0.1 not supported
Comment 16 salsaman 2015-12-23 16:14:02 CET
./configure --disable-projectM is recommended.
Comment 17 A. Trande (sagitter) 2015-12-23 16:29:53 CET
(In reply to comment #16)
> ./configure --disable-projectM is recommended.

Okay.

SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-4.fc23.src.rpm
Comment 18 A. Trande (sagitter) 2015-12-23 19:33:23 CET
@salsaman

Please, take a look to this issue: http://sourceforge.net/p/lives/bugs/210/
Comment 19 salsaman 2015-12-23 20:15:22 CET
I was unable to reproduce the bug on Ubuntu 15.10 64 bit. I don't have a Fedora box to test on at the moment.

I suspect this user may have some odd kind of set up, since the error messages look very strange, and the final crash occurs in a normal gtk+ function.

Is anyone else able to reproduce it ? The steps are quite straightforward (install LiVES, Click on File / Open Location Stream / Open Youtube clip, enter URL of a Youtube clip, wait for download to complete / fail, then press ctrl-p).
Comment 20 GerhardK 2015-12-26 23:01:26 CET
I've build Lives from the last src.rpm posted here and installed it on a machine running an up to date Fedora 23/64bit. Imported a youtube-clip and everything went fine. The clip was imported properly (showing as webm-video) and there were no crashes at all. 

"Downloading https://www.youtube.com/watch?v=LdSqPPRPI1o to /home/gerhard/Videos/.webm...Opening /home/gerhard/Videos/.webm using LiVES mkv decoder version 1.2
Frames=7455 type=mkv/vp8/unknown size=480x360 bpp=32 fps=25.000
Audio: 44100 Hz 2 channels 16 bps"

PS: A big, big thank you to the developer of Lives and also to the packager. It would be great to see this fine videoeditor in rpmfusion.
Comment 21 A. Trande (sagitter) 2015-12-27 18:22:22 CET
(In reply to comment #20)
> I've build Lives from the last src.rpm posted here and installed it on a
> machine running an up to date Fedora 23/64bit. Imported a youtube-clip and
> everything went fine. The clip was imported properly (showing as webm-video)
> and there were no crashes at all. 
> 
> "Downloading https://www.youtube.com/watch?v=LdSqPPRPI1o to
> /home/gerhard/Videos/.webm...Opening /home/gerhard/Videos/.webm using LiVES mkv
> decoder version 1.2
> Frames=7455 type=mkv/vp8/unknown size=480x360 bpp=32 fps=25.000
> Audio: 44100 Hz 2 channels 16 bps"
> 
> PS: A big, big thank you to the developer of Lives and also to the packager. It
> would be great to see this fine videoeditor in rpmfusion.

Can you select Tools-->Preference without crash? If yes, which DE (Gnome, XFce, KDE) are you using?
Comment 22 GerhardK 2015-12-28 01:21:45 CET
I'm using Xfce and no, I can't open "Tools - Preferences", it is followed by an immediate crash of Lives:

#0  0x00007fed93c375db in waitpid () at /lib64/libpthread.so.0
#1  0x00007fed96adb9a3 in g_on_error_stack_trace () at /lib64/libglib-2.0.so.0
#2  0x000056501bbb6a3a in catch_sigint ()
#3  0x00007fed93c379f0 in <signal handler called> () at /lib64/libpthread.so.0
#4  0x00007fed96e29703 in g_type_check_is_value_type ()
#5  0x00007fed9877d9a5 in _gtk_tree_data_list_check_type ()
#6  0x00007fed986787c1 in gtk_list_store_newv () at /lib64/libgtk-3.so.0
#7  0x000056501bbb03ff in lives_list_store_new ()
#8  0x000056501bc34560 in create_prefs_dialog ()
#9  0x000056501bc3e436 in on_preferences_activate ()
#10 0x00007fed96e047a5 in g_closure_invoke () at /lib64/libgobject-2.0.so.0
#11 0x00007fed96e16851 in signal_emit_unlocked_R ()
#12 0x00007fed96e1f530 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
#13 0x00007fed96e1f8ff in g_signal_emit () at /lib64/libgobject-2.0.so.0
#14 0x00007fed987bdace in gtk_widget_activate () at /lib64/libgtk-3.so.0
#15 0x00007fed9869b576 in gtk_menu_shell_activate_item ()
#16 0x00007fed9869b8a4 in gtk_menu_shell_button_release ()
#17 0x00007fed9867e03a in _gtk_marshal_BOOLEAN__BOXEDv ()
#18 0x00007fed96e049d4 in _g_closure_invoke_va () at /lib64/libgobject-2.0.so.0
#19 0x00007fed96e1edd3 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
#20 0x00007fed96e1f8ff in g_signal_emit () at /lib64/libgobject-2.0.so.0
#21 0x00007fed987bb63c in gtk_widget_event_internal () at /lib64/libgtk-3.so.0
#22 0x00007fed9867b3ae in propagate_event () at /lib64/libgtk-3.so.0
#23 0x00007fed9867d15c in gtk_main_do_event () at /lib64/libgtk-3.so.0
#24 0x00007fed981f5a42 in gdk_event_source_dispatch () at /lib64/libgdk-3.so.0
#25 0x00007fed96b05e3a in g_main_context_dispatch () at /lib64/libglib-2.0.so.0
#26 0x00007fed96b061d0 in g_main_context_iterate.isra ()
#27 0x00007fed96b064f2 in g_main_loop_run () at /lib64/libglib-2.0.so.0
#28 0x00007fed9867c385 in gtk_main () at /lib64/libgtk-3.so.0
#29 0x000056501bbbdcdc in real_main ()
#30 0x00007fed93886580 in __libc_start_main () at /lib64/libc.so.6
#31 0x000056501bbac7f9 in _start ()

It's exactly identical to what's been already mentioned and posted on sourceforge: http://sourceforge.net/p/lives/bugs/210/
Comment 23 salsaman 2015-12-28 02:49:55 CET
OK, let's try to debug this. Please try these things in sequence:

edit preferences.c, and find the line:

store = lives_list_store_new(N_COLUMNS, LIVES_COL_TYPE_PIXBUF, LIVES_COL_TYPE_STRING, LIVES_COL_TYPE_UINT);

replace this with (recompile and test each time):

1) store = gtk_list_store_new(N_COLUMNS, LIVES_COL_TYPE_PIXBUF, LIVES_COL_TYPE_STRING, LIVES_COL_TYPE_UINT);

2) store = gtk_list_store_new(3, GDK_TYPE_PIXBUF, G_TYPE_STRING, G_TYPE_UINT);


3) store = gtk_list_store_new(3, G_TYPE_INT, G_TYPE_INT, G_TYPE_INT);
Comment 24 A. Trande (sagitter) 2015-12-28 11:01:50 CET
(In reply to comment #23)
> OK, let's try to debug this. Please try these things in sequence:
> 
> edit preferences.c, and find the line:
> 
> store = lives_list_store_new(N_COLUMNS, LIVES_COL_TYPE_PIXBUF,
> LIVES_COL_TYPE_STRING, LIVES_COL_TYPE_UINT);
> 
> replace this with (recompile and test each time):
> 
> 1) store = gtk_list_store_new(N_COLUMNS, LIVES_COL_TYPE_PIXBUF,
> LIVES_COL_TYPE_STRING, LIVES_COL_TYPE_UINT);
> 
> 2) store = gtk_list_store_new(3, GDK_TYPE_PIXBUF, G_TYPE_STRING, G_TYPE_UINT);
> 
> 
> 3) store = gtk_list_store_new(3, G_TYPE_INT, G_TYPE_INT, G_TYPE_INT);

@salsaman

Please, don't discuss of this here; this ticket is only for packaging review.
I will reply in http://sourceforge.net/p/lives/bugs/210/.

Thank you very much.
Comment 25 salsaman 2015-12-28 15:04:09 CET
OK, hopefully that is fixed now. Some other tips for packaging:

- you can create a custom startup script in /usr/bin/lives. Here you can set any environment variables. At the end you should call <prefix>/bin/lives-exe $@.

- if you are using multilibs, e.g. /usr/lib64 instead of /usr/lib, you need to compile with ./configure --libdir=/usr/lib64. You MUST also edit the pkg-config files *.pc in libweed.
Comment 26 A. Trande (sagitter) 2015-12-28 17:30:38 CET
SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-5.fc23.src.rpm

- Patched to fix Tools->Preference menu crash
Comment 27 A. Trande (sagitter) 2015-12-28 17:36:29 CET
(In reply to comment #25)
> OK, hopefully that is fixed now. Some other tips for packaging:
> 
> 
> - if you are using multilibs, e.g. /usr/lib64 instead of /usr/lib, you need to
> compile with ./configure --libdir=/usr/lib64. You MUST also edit the pkg-config
> files *.pc in libweed.

Since libweed is a private library used only by LiVES, I prefer to leave out its devel files (header and .pc). At least, until when you decide to distribute libweed with an its own source archive separated from LiVES.
Comment 28 A. Trande (sagitter) 2015-12-29 22:04:56 CET
SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-6.fc23.src.rpm

- Update from revision 2353
- libvisual support disabled

@Sergio
I think this is defintive release ready for review.
Comment 29 Sérgio Basto 2016-01-13 21:12:38 CET
Created attachment 1541 [details]
lives.dmitry.spec

(In reply to comment #28)
> SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
> SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-6.fc23.src.rpm
> 
> - Update from revision 2353
> - libvisual support disabled
> 
> @Sergio
> I think this is defintive release ready for review.

Hello , I have one previous .spec ( lives.dmitry.spec ) and you miss some scripts, but first talk about LiVES.appdata.xml , shouldn't be in spec ! we should upstream , or add as a file to upstream it later . 
Source1: LiVES.appdata.xml
install -Dp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/appdata/LiVES.appdata.xml

I think you should use desktop-file-install :
-desktop-file-edit \
+desktop-file-install \

we could add some doc:
 %files -f %{name}.lang
 %doc README AUTHORS BUGS ChangeLog FEATURES
+%doc GETTING.STARTED NEWS OMC/*.txt RFX/*

you also miss , I think not sure ldconfig and update-desktop-database

%post -p /sbin/ldconfig
update-desktop-database &> /dev/null || :

%postun -p /sbin/ldconfig
update-desktop-database &> /dev/null || :

All others things are good and ready to be approved . 
Thanks.
Comment 30 Sérgio Basto 2016-01-13 21:13:24 CET
Created attachment 1542 [details]
LiVES.appdata.xml

Source1
Comment 31 A. Trande (sagitter) 2016-01-13 22:10:22 CET
(In reply to comment #29)
> Created attachment 1541 [details]
> lives.dmitry.spec
> 
> (In reply to comment #28)
> > SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
> > SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-6.fc23.src.rpm
> > 
> > - Update from revision 2353
> > - libvisual support disabled
> > 
> > @Sergio
> > I think this is defintive release ready for review.
> 
> Hello , I have one previous .spec ( lives.dmitry.spec ) and you miss some
> scripts, but first talk about LiVES.appdata.xml , shouldn't be in spec ! we
> should upstream , or add as a file to upstream it later . 
> Source1: LiVES.appdata.xml
> install -Dp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/appdata/LiVES.appdata.xml

Well, there is not any original appdata-file in source archive from upstream, I made one directly. Nothing prevents me to make an appdata file during building (see https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation). Of course, if upstream maintainer (in copy in this ticket) wishes to include it and use his own screeshots, better.

> 
> I think you should use desktop-file-install :
> -desktop-file-edit \
> +desktop-file-install \

Why? desktop-file-edit and desktop-file-install are almost same command. See 'man desktop-file-edit'

> 
> we could add some doc:
>  %files -f %{name}.lang
>  %doc README AUTHORS BUGS ChangeLog FEATURES
> +%doc GETTING.STARTED NEWS OMC/*.txt RFX/*

Okay.

> 
> you also miss , I think not sure ldconfig and update-desktop-database
> 
> %post -p /sbin/ldconfig
> update-desktop-database &> /dev/null || :
> 
> %postun -p /sbin/ldconfig
> update-desktop-database &> /dev/null || :
> 

ldconfig is invoked when libraries are shared, so installed in /usr/lib directory; libweed are private libraries, installed in a /usr/lib sub-directory and used by LiVES only. (See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries)

lives.desktop has not a MimeType key; why should I invoke update-desktop-database? 
(http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database)
Comment 32 Sérgio Basto 2016-01-13 22:28:15 CET
(In reply to comment #31)
OK arguments accepted, just left 2 things, please add docs that you said ok, and about [1] 
"You can do this by including a .appdata.xml file you create as a Source: (e.g. Source3: %{name}.appdata.xml) or generating it in the spec file" 

I prefer the first option, is more easy to upstream it more easy to fix it, more readable and the .spec looks much more clean, but it is optional . 

[1]
https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation


Thanks.
Comment 33 A. Trande (sagitter) 2016-01-13 22:54:33 CET
(In reply to comment #32)
> (In reply to comment #31)
> OK arguments accepted, just left 2 things, please add docs that you said ok,
> and about [1] 
> "You can do this by including a .appdata.xml file you create as a Source: (e.g.
> Source3: %{name}.appdata.xml) or generating it in the spec file" 
> 
> I prefer the first option, is more easy to upstream it more easy to fix it,
> more readable and the .spec looks much more clean, but it is optional . 
> 
> [1]
> https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation
> 
> 
> Thanks.

SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-7.fc23.src.rpm
Comment 34 Sérgio Basto 2016-01-14 01:03:14 CET
(In reply to comment #31)
> Well, there is not any original appdata-file in source archive from upstream, I
> made one directly. (...)
> Of course, if upstream maintainer (in copy in this ticket) wishes to include it
> and use his own screenshots, better.

Yes, we should try upstream LiVES.appdata.xml ;) , for curiosity why you drop the screenshot http://lives-video.com/images/lives_mtw.png [1] ? 

Package approved .

Thanks.

[1] 
diff LiVES.appdata.xml.old LiVES.appdata.xml.new
(...)
   <screenshots>
+    <screenshot type="default">https://sagitter.fedorapeople.org/lives-screenshot/lives.png</screenshot>
+    <screenshot>https://sagitter.fedorapeople.org/lives-screenshot/lives2.png</screenshot>
-    <screenshot type="default">http://lives-video.com/images/lives_mtw.png</screenshot>
   </screenshots>
Comment 35 salsaman 2016-01-14 02:44:45 CET
Sure, I can add the appdata file to the source. Where is the best place for it ? I can create an RPMFusion subdirectory if you like.

You may wish to hold off on the release for a few days; I am planning on releasing 2.4.7 at the weekend. It has all of the fixes mentioned here plus it fixes a couple of other minor issues.
Comment 36 Sérgio Basto 2016-01-14 05:06:40 CET
(In reply to comment #35)
> Sure, I can add the appdata file to the source. Where is the best place for it
> ? I can create an RPMFusion subdirectory if you like.

In root or if you have "data" dir in "data" dir or if you don't like the idea have it on root, appdata/ dir .
Comment 37 A. Trande (sagitter) 2016-01-14 11:31:55 CET
(In reply to comment #34)
> type="default">http://lives-video.com/images/lives_mtw.png</screenshot>
>    </screenshots>

 Screenshot size, shape and format:

-  All screenshots should have a 16:9 aspect ratio, and should have a width that is no smaller than 620px (this will ensure that your screenshots correctly fit into the space provided by the software application). Ideally the window will be resized to a 16:9 aspect ratio, but screenshots can also be cropped if only a small area of the window needs to be shown.
- Screenshots should be in PNG or JPEG format. PNG is the preferred format; JPEG should only be used when screenshots include large photographs or other images where a lossy format JPEG format may compress better.
- Do not scale screenshots below their original size.

See http://people.freedesktop.org/~hughsient/appdata/
Comment 38 salsaman 2016-01-14 15:44:35 CET
I can add appdata to root, that is no problem. But the problem is knowing the FC release number (e.g. 2.4.6-6.fc23 and timestamp. Perhaps the best way is for somebody to email it to me after release and then I can add it to svn.
Comment 39 Sérgio Basto 2016-01-14 15:54:35 CET
(In reply to comment #38)
> I can add appdata to root, that is no problem. But the problem is knowing the
> FC release number (e.g. 2.4.6-6.fc23 and timestamp. Perhaps the best way is for
> somebody to email it to me after release and then I can add it to svn.

use this line instead (from last src.rpm) :
<release version="%{version}-%{release}" timestamp="1450483200" />
Comment 40 A. Trande (sagitter) 2016-01-14 15:58:00 CET
(In reply to comment #38)
> I can add appdata to root, that is no problem. But the problem is knowing the
> FC release number (e.g. 2.4.6-6.fc23 and timestamp. Perhaps the best way is for
> somebody to email it to me after release and then I can add it to svn.

You can also remove FC release, it's not a problem:
http://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-releases
http://www.freedesktop.org/software/appstream/docs/chap-DistroData.html#tag-distro-releases
Comment 41 salsaman 2016-01-15 17:31:58 CET
OK, added appdata in the root directory: https://sourceforge.net/p/lives/code/HEAD/tree/trunk/LiVES.appdata.xml

When I come to do the next release I'll check if I have any suitable screenshots to add, otherwise the ones that are there will do for now.
Comment 42 A. Trande (sagitter) 2016-01-15 17:40:17 CET
(In reply to comment #41)
> OK, added appdata in the root directory:
> https://sourceforge.net/p/lives/code/HEAD/tree/trunk/LiVES.appdata.xml
> 
> When I come to do the next release I'll check if I have any suitable
> screenshots to add, otherwise the ones that are there will do for now.

Thank you.
If next release will come in some days, I can wait before commit first packaging release.
Comment 43 salsaman 2016-01-16 22:46:15 CET
Are these screenshots OK for the appdata ?

http://lives-video/images/livescess.png
http://lives-video/images/livesmtss.png

If not I can change them. Aiming to release in the next day or 2.
Comment 44 salsaman 2016-01-16 22:47:08 CET
There should be an edit button...

http://lives-video.com/images/livescess.png
http://lives-video.com/images/livesmtss.png
Comment 45 A. Trande (sagitter) 2016-01-16 23:12:14 CET
(In reply to comment #43)
> Are these screenshots OK for the appdata ?
> 
> http://lives-video/images/livescess.png
> http://lives-video/images/livesmtss.png
> 
> If not I can change them. Aiming to release in the next day or 2.

(In reply to comment #44)
> There should be an edit button...
> 
> http://lives-video.com/images/livescess.png
> http://lives-video.com/images/livesmtss.png

They're okay.
Comment 46 Nicolas Chauvet 2016-01-17 11:05:32 CET
(In reply to comment #44)
> There should be an edit button...
> 
> http://lives-video.com/images/livescess.png
> http://lives-video.com/images/livesmtss.png

Theses screenshots seem related to a well known commercial serie. I don't expect it's okay given the authorship of images related to this serie. I request that theses screenshot be changed to show pictures from creative commons content. (such as blender movies or else).
Comment 47 salsaman 2016-01-18 01:59:24 CET
Hi, I have released LiVES 2.4.7: http://lives-video.com/releases/LiVES-2.4.7.tar.bz2

I'll change the screenshots as per request by Nicholas. In the meantime feel free to test /verify the new version.
Comment 48 salsaman 2016-01-18 02:31:22 CET
Screenshots updated to use CC material.
Comment 50 A. Trande (sagitter) 2016-01-18 12:15:35 CET
Package CVS request
======================
Package Name: lives
Short Description: Video editor and VJ tool
Owners: sagitter
Branches: f22 f23
----------------------
License tag: free
Comment 51 salsaman 2016-01-20 01:27:47 CET
One bugfix has been made since th release: https://sourceforge.net/p/lives/code/2363/tree//trunk/smogrify?diff=505487e4bfc09e4ced4d35a9:2362

If possible please apply this patch before releasing (fixes a hang in Merge in the Clip Editor).
Comment 52 A. Trande (sagitter) 2016-01-20 11:54:50 CET
(In reply to comment #51)
> One bugfix has been made since th release:
> https://sourceforge.net/p/lives/code/2363/tree//trunk/smogrify?diff=505487e4bfc09e4ced4d35a9:2362
> 
> If possible please apply this patch before releasing (fixes a hang in Merge in
> the Clip Editor).

New release:

SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.7-2.fc23.src.rpm
Comment 53 salsaman 2016-01-24 16:19:32 CET
LiVES 2.4.8 released:


http://lives-video.com/releases/LiVES-2.4.8.tar.bz2
(source bzip2, 3.7 MB)

http://lives-video.com/releases/LiVES-2.4.8.tar.gz
(source gzip, 5.2 MB)

(If you can provide me with a packager email I can send notifications there rather than keep commenting here).
Comment 54 A. Trande (sagitter) 2016-01-24 17:37:52 CET
(In reply to comment #53)
> LiVES 2.4.8 released:
> 
> 
> http://lives-video.com/releases/LiVES-2.4.8.tar.bz2
> (source bzip2, 3.7 MB)
> 
> http://lives-video.com/releases/LiVES-2.4.8.tar.gz
> (source gzip, 5.2 MB)
> 

Thank you.

SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.8-1.fc23.src.rpm

> (If you can provide me with a packager email I can send notifications there
> rather than keep commenting here).

Don't worry, I check periodically all updates of packages which I maintain.
However you can contact me at 'sagitter AT fedoraproject.org'
Comment 55 salsaman 2016-01-24 18:43:11 CET
Thanks, I will add you to the email list, that way you will also get the release notes and any follow up messages.

Can you let me know the URL for the binary packages, I would like to add a link from the downloads page.
Comment 56 A. Trande (sagitter) 2016-01-24 19:24:01 CET
(In reply to comment #55)
> Can you let me know the URL for the binary packages, I would like to add a link
> from the downloads page.

Well, I hope we can provide LiVES directly by RPM Fusion soon.
I have uploaded LiVES binary packages for Fedora 23/24 x86_64/i386 here

https://sagitter.fedorapeople.org/lives/

until inclusion on RPM Fusion repositories is complete.
To be installed on Fedora 23, it needs that rpmfusion-free and rpmfusion-free-updates-testing repos are enabled.
Comment 57 Sérgio Basto 2016-01-25 18:48:33 CET
Hi, 
Many thanks to bring Lives into RPMFusion / Fedora. 
As you may aware RPMFusion is moving infrastructure to git / koji, unfortunately this is taking several months, almost years and I don't see when will be complete. So don't expect an fast inclusion on RPM Fusion repositories, because none package was included since then.
Also don't block #3821 , because that is just for included packages.
Anyway this is valuable work , with or without RPM Fusion.
Comment 58 A. Trande (sagitter) 2016-01-31 17:31:44 CET
> As you may aware RPMFusion is moving infrastructure to git / koji,
> unfortunately this is taking several months, almost years and I don't see when
> will be complete. So don't expect an fast inclusion on RPM Fusion repositories,
> because none package was included since then.
> Also don't block #3821 , because that is just for included packages.
> Anyway this is valuable work , with or without RPM Fusion.

@salsaman

SPEC files and RPMs of LiVES are hosted in a dedicated space on github.com:
https://github.com/sagitter/lives

Please, refer to them unti when RPM Fusion's infrastructure is ready.
Comment 59 A. Trande (sagitter) 2016-07-07 23:09:47 CEST
Please, create a GIT repository for lives.

Package CVS request
======================
Package Name: lives
Short Description: Video editor and VJ tool
Owners: sagitter
Branches: f23 f24 f25
----------------------
License tag: free
Comment 60 A. Trande (sagitter) 2016-07-09 20:32:23 CEST
LiVES built on Fedora 23 and 24.
Comment 61 leigh scott 2016-08-18 14:36:50 CEST
*** Bug 4204 has been marked as a duplicate of this bug. ***