Bug 4013

Summary: Review request: devedeng - A program to create video DVDs and CDs (VCD, sVCD or CVD)
Product: Package Reviews Reporter: Andrea Musuruane <musuruan>
Component: Review RequestAssignee: RPM Fusion Package Review <rpmfusion-package-review>
Status: RESOLVED FIXED    
Severity: normal CC: leigh123linux, rpmfusion-package-review, sergio
Priority: P5    
Version: Current   
Hardware: All   
OS: GNU/Linux   
namespace:
Bug Depends on:    
Bug Blocks: 4    

Description Andrea Musuruane 2016-03-19 14:36:33 CET 
Spec file:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng.spec

Source RPM:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng-4.6.1.tar.gz

Description:
DevedeNG is a program to create video DVDs and CDs (VCD, sVCD or CVD), 
suitable for home players, from any number of video files, in any of the 
formats supported by FFMpeg.  

The suffix NG is because it is a rewrite from scratch of the old Devede, to 
work with Python3 and Gtk3, and with a new internal architecture that allows 
to expand it and easily add new features.

Why this package is not eligible to be included in Fedora?
It depends on other packages in RPM Fusion.

Rpmlint:
$ rpmlint /home/andrea/rpmbuild/SRPMS/devedeng-4.6.1-1.fc23.src.rpm
devedeng.src: W: spelling-error Summary(en_US) sVCD -> scud
devedeng.src: W: spelling-error %description -l en_US sVCD -> scud
devedeng.src: W: spelling-error %description -l en_US suitables -> suitable, suitable s, suitably
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint /home/andrea/rpmbuild/RPMS/noarch/devedeng-4.6.1-1.fc23.noarch.rpm
devedeng.noarch: E: explicit-lib-dependency python3-urllib3
devedeng.noarch: W: spelling-error Summary(en_US) sVCD -> scud
devedeng.noarch: W: spelling-error %description -l en_US sVCD -> scud
devedeng.noarch: W: spelling-error %description -l en_US suitables -> suitable, suitable s, suitably
devedeng.noarch: W: no-manual-page-for-binary devede_ng.py
devedeng.noarch: W: no-manual-page-for-binary copy_files_verbose.py
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

The "explicit-lib-dependency" error is erroneously raised by rpmlint because it the package name has lib in its name. 

Warnings can be safely ignored.
Comment 1 Andrea Musuruane 2016-04-25 11:05:42 CEST 
Spec file:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng.spec

Source RPM:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng-4.7.0-1.fc23.src.rpm

Changelog:
- Updated to new upstream release
Comment 2 Sérgio Basto 2016-07-11 20:59:57 CEST 
The package seems simple , after running:

fedora-review --other-bz https://bugzilla.rpmfusion.org -b 4013 -m fedora-24-x86_64-rpmfusion_free

No blocker issues, 
Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
it is normal we don't vcdimager in build root 

Rpmlint
-------
Checking: devedeng-4.7.0-1.fc24.noarch.rpm
          devedeng-4.7.0-1.fc24.src.rpm
devedeng.noarch: W: spelling-error Summary(en_US) sVCD -> scud
devedeng.noarch: W: spelling-error %description -l en_US sVCD -> scud
devedeng.noarch: W: no-manual-page-for-binary devede_ng.py
devedeng.noarch: W: no-manual-page-for-binary copy_files_verbose.py
devedeng.src: W: spelling-error Summary(en_US) sVCD -> scud
devedeng.src: W: spelling-error %description -l en_US sVCD -> scud
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

6 warnings.

nothing that can be improved .

Package APPROVED !
Comment 3 Andrea Musuruane 2016-07-12 11:30:42 CEST 
(In reply to comment #2)
> The package seems simple , after running:
> 
> fedora-review --other-bz https://bugzilla.rpmfusion.org -b 4013 -m
> fedora-24-x86_64-rpmfusion_free
> 
> No blocker issues, 
> Note: Mock build failed
>      See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
> it is normal we don't vcdimager in build root 

The problem must be another one because vcdimager is not required to build the package.

> Package APPROVED !

Thanks for the review!
Comment 4 Andrea Musuruane 2016-07-12 11:34:36 CEST 
Package CVS request
======================
Package Name: devedeng
Short Description: A program to create video DVDs and CDs (VCD, sVCD or CVD)
Owners: musuruan
Branches: F23 F24
InitialCC:
----------------------
License tag: free
Comment 5 Andrea Musuruane 2016-08-04 14:14:16 CEST 
Imported and built.