| Summary: | Review request: fs-uae - Amiga emulator with on-screen GUI and online play support | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Andrea Musuruane <musuruan> |
| Component: | Review Request | Assignee: | Nicolas Chauvet <kwizart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | leigh123linux, packages, rpmfusion-package-review |
| Priority: | P5 | Flags: | kwizart:
fedora-review+
|
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| namespace: | free | ||
| Bug Depends on: | |||
| Bug Blocks: | 4028, 4029 | ||
|
Description
Andrea Musuruane
2016-04-10 18:39:13 CEST
I properly fixed FTBFS with GCC 6. Spec file: https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae.spec Source RPM: https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae-2.6.2-2.fc23.src.rpm My rpm building foo is a bit rusty these days, but a missing build dep? g++ -DHAVE_CONFIG_H -I. -DLINUX -DUAE -DFSUAE -I./flac/include -I./gen -I./src -I./src/jit -I./src/include -I./src/od-fs -I./src/od-fs/include -I./src/od-win32 -I./src/od-win32/caps -I./libfsemu/include -I./manymouse -I./src/slirp/include -I./libudis86/include -I./prowizard/include -I./softfloat -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/GL -I/usr/include/libdrm -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DLUA_USE_POSIX -I/usr/include/AL -I/usr/include/libdrm -I/usr/include/libpng16 -D_REENTRANT -I/usr/include/SDL2 -fno-strict-overflow -Wmissing-declarations -Waddress -fvisibility=hidden -I/usr/include/mpeg2dec -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -c -o src/missing.o src/missing.cpp make: g++: Command not found Makefile:4153: recipe for target 'src/missing.o' failed make: *** [src/missing.o] Error 127 make: *** Waiting for unfinished jobs.... error: Bad exit status from /var/tmp/rpm-tmp.6pxOVI (%build) (In reply to comment #2) > My rpm building foo is a bit rusty these days, but a missing build dep? Hi Ian. It's nice to see you still around :) When I submitted this review request I build it with mock even for rawhide. Maybe something have changed meanwhile. BTW, can you please specify the Fedora release and the arch you were building for? Can you also try using mock? Hi, yep still lurking around and still use Linux every day :-) Yes sorry, I should have mentioned that. This was FC23 x86_64 - fully updated. A fairly new install in a VM so there weren't too many packages pre-installed. Obviously once I installed gcc-c++ it built perfectly fine. Oh... and yes, I'll give it a go in mock and let you know. Looking at mock, gcc-c++ is part of the group "Buildsystem building group" and so is installed by mock. But it's not installed by default on a new system, or mandatory so the RPM can file. I guess that's acceptable by Fedora policy. review url produce a 404, please re-open if still relevant. (In reply to Nicolas Chauvet from comment #7) > review url produce a 404, please re-open if still relevant. Links probably broken due to Dropbox. I'll update them next week. https://www.dropbox.com/s/k2nil8svmwyli6y/fs-uae.spec?dl=0 https://www.dropbox.com/s/xfzpcgj01es4qro/fs-uae-2.6.2-2.fc23.src.rpm?dl=0 (In reply to Andrea Musuruane from comment #9) > https://www.dropbox.com/s/k2nil8svmwyli6y/fs-uae.spec?dl=0 > https://www.dropbox.com/s/xfzpcgj01es4qro/fs-uae-2.6.2-2.fc23.src.rpm?dl=0 The spec file (at least), is not publicly accessible (I need to create an account). (In reply to Nicolas Chauvet from comment #10) > The spec file (at least), is not publicly accessible (I need to create an > account). No registration in required. Just ignore the registration box and you'll be proposed a download option. This is not an easy way to cope with fedora-review So here is a quick review. please use %make_build macro (as you are using %make_install one). Please drop https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database Not needed on f24+ This package is APPROVED Thanks for your review. I'll try to build the package ASAP. (In reply to Andrea Musuruane from comment #13) > Thanks for your review. I'll try to build the package ASAP. please request the package in pkgdb2 and remind that we have branched f27 just now. Package processed Package imported and built. fs-uae-arcade (#4028) and fs-uae-launcher (#4029) are still awaiting for a reviewer. I'm available to swap reviews. @Andrea With libmpeg2 moved in fedora, is there any remaining reason not to move this package into fedora ? FYI this was raised on twitter: https://twitter.com/Midar3/status/1396099426712789003 (In reply to Nicolas Chauvet from comment #18) > @Andrea > With libmpeg2 moved in fedora, is there any remaining reason not to move > this package into fedora ? > FYI this was raised on twitter: > https://twitter.com/Midar3/status/1396099426712789003 We cannot move fs-uae to Fedora because it depends on kickstart ROM files to function. This is forbidden by Fedora policy: "Emulators which depend on firmware or ROM files to function may not be included in Fedora, unless the copyright holder(s) for the firmware/ROM files give clear permission for the firmware/ROM files to be distributed (either under a Fedora permissible license or under the Fedora firmware exception criteria)." https://fedoraproject.org/wiki/Licensing:SoftwareTypes#Emulators Kickstart ROMs are copyrighted (and sold) by Cloanto: https://www.amigaforever.com/ Thanks for clarification. |