Bug 4029

Summary:	Review request: fs-uae-arcade - Fullscreen game browser for FS-UAE
Product:	Package Reviews	Reporter:	Andrea Musuruane <musuruan>
Component:	Review Request	Assignee:	Ben Rosser <rosser.bjr>
Status:	RESOLVED FIXED
Severity:	normal	CC:	rosser.bjr, rpmfusion-package-review
Priority:	P5	Flags:	rosser.bjr: fedora-review+
Version:	Current
Hardware:	All
OS:	GNU/Linux
namespace:	free
Bug Depends on:	4027
Bug Blocks:

Description Andrea Musuruane 2016-04-10 18:48:28 CEST

Spec file:
https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae-arcade.spec

Source RPM:
https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae-arcade-2.6.2-1.fc23.src.rpm

Description:
https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae-arcade-2.6.2-1.fc23.src.rpm

Why is this package not eligible to be included in Fedora?
It depends on FS-UAE.

rpmlint output:
[andrea@panoramix SPECS]$ rpmlint /home/andrea/rpmbuild/SRPMS/fs-uae-arcade-2.6.2-1.fc23.src.rpm
fs-uae-arcade.src: W: spelling-error Summary(en_US) Fullscreen -> Full screen, Full-screen, Firescreen
fs-uae-arcade.src: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[andrea@panoramix SPECS]$ rpmlint /home/andrea/rpmbuild/RPMS/noarch/fs-uae-arcade-2.6.2-1.fc23.noarch.rpm
fs-uae-arcade.noarch: W: spelling-error Summary(en_US) Fullscreen -> Full screen, Full-screen, Firescreen
fs-uae-arcade.noarch: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen
fs-uae-arcade.noarch: W: no-documentation
fs-uae-arcade.noarch: W: no-manual-page-for-binary fs-uae-arcade
fs-uae-arcade.noarch: W: uncompressed-zip /usr/share/fs-uae-arcade/fsbc/tests/zipfile/utf-8.zip
fs-uae-arcade.noarch: W: uncompressed-zip /usr/share/fs-uae-arcade/fsbc/tests/zipfile/iso-8859-1.zip
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

Comment 1 Andrea Musuruane 2017-08-06 17:47:16 CEST

https://www.dropbox.com/s/xex0anu8x7bunn7/fs-uae-arcade.spec?dl=0
https://www.dropbox.com/s/0y88eel91qz1rml/fs-uae-arcade-2.6.2-1.fc23.src.rpm?dl=0

Comment 2 Andrea Musuruane 2017-09-09 21:09:31 CEST

https://www.dropbox.com/s/xex0anu8x7bunn7/fs-uae-arcade.spec?dl=0
https://www.dropbox.com/s/rlir7hzcsn2dguj/fs-uae-arcade-2.8.3-1.fc26.src.rpm?dl=0

Changelog:
- Updated to new upstream version

Comment 3 Andrea Musuruane 2017-09-16 19:35:00 CEST

https://www.dropbox.com/s/ex4xxos6533fl3b/fs-uae-arcade.spec?dl=0
https://www.dropbox.com/s/yfswmfl9dclrg9b/fs-uae-arcade-2.8.3-2.fc26.src.rpm?dl=0

Changelog:
- Relaxed fs-uae requires

Comment 4 Andrea Musuruane 2017-10-15 19:45:02 CEST

https://www.dropbox.com/s/6z15a2d0kywrs2p/fs-uae-arcade.spec?dl=0
https://www.dropbox.com/s/vqxv4gyrgfzl1sy/fs-uae-arcade-2.8.3-3.fc26.src.rpm?dl=0

Changelog:
- Added a virtual provide to note oyoyo is bundled
- Amended License tag
- Added AppData file
- Removed six python library
- Unbundled font file

Comment 5 Ben Rosser 2017-11-27 23:52:20 CET

I'm sorry this took so long for me to get to.

The package looks mostly fine, and appears to be very similar to fs-uae-launcher. One thing from rpmlint that caught my eye was the following:

fs-uae-arcade.noarch: W: uncompressed-zip /usr/share/fs-uae-arcade/fsbc/tests/zipfile/iso-8859-1.zip
The zip file is not compressed.

fs-uae-arcade.noarch: W: uncompressed-zip /usr/share/fs-uae-arcade/fsbc/tests/zipfile/utf-8.zip
The zip file is not compressed.

The zip files in question aren't very large; they are an insignificant contribution to the package's size. However, it looks like they are there because there are some tests in some of the Python directories (that require python3-mypy). It might be good to run them in %check, if it's feasible.

However this isn't a blocker, so I'm going to go ahead and APPROVE it.

Comment 6 Andrea Musuruane 2017-12-09 16:44:25 CET

Thanks for the review, Ben!

Imported and built.

Closing!