Bug 4256

1. Remove
%global         gituser         Aegisub
%global         gitname         Aegisub
And use %{url instead of https://github.com/%{gituser}/%{gitname} in Source0.

2. Change
%autosetup -n %{gitname}-%{version} -p 1
to
%autosetup -n Aegisub-%{version} -p 1

It is not so often used to make %global macro.

3. Remove rm -rf %{buildroot}.

4. Make desktop-file validation.

Hello Vasiliy,
thanks for review.

>1. Remove
>It is not so often used to make %global macro.
I would prefer to keep the github macros. I believe it is quite common in the Fedora SPECS and I believe there is no rule which should say I must not use that.

>3. Remove rm -rf %{buildroot}.
>4. Make desktop-file validation.
I Will do.

Mik

Also simplify
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*

to
%{_datadir}/%{name}

And add
Requires:       hicolor-icon-theme

And add
BuildRequires:	intltool

Check build for rawhide instead of F23.

And I recommend add --without-openal to %configure

SPEC: https://rebus.fedorapeople.org/SPECS/aegisub.spec
SRPM: https://rebus.fedorapeople.org/SRPMS/aegisub-3.2.2-2.fc23.src.rpm

1. As you can see in build.log http://koji.russianfedora.pro/kojifiles/work/tasks/106/90106/build.log
OpenAL doesn't work an disabled. So I recommend add --without-openal to configure.

2. I think it is better remove version suffix from bin-file name.
Add before configure:
#remove version postfix
sed -e 's/aegisub-3\.2/aegisub/' -e 's/aegisub-32/aegisub/' -i configure

Change 
%find_lang %{name}
%files -f %{name}-32.lang
%{_bindir}/%{name}*

to
%find_lang %{name}
%files -f %{name}.lang
%{_bindir}/%{name}

I used your suggestion to remove the version.

Regarding openal - seems I was having missing dependency to libcxx-devel which is used when checking presence for openal-devel. But it seems to work fine on FC23 and FC24 so why not to keep in the support for it. Unfortunately my copr respository with ffms2 and aegisub was removed without notice earlier than I was able to check whether it worked or not for rawhide.

SPEC: https://rebus.fedorapeople.org/SPECS/aegisub.spec
SRPM: https://rebus.fedorapeople.org/SRPMS/aegisub-3.2.2-3.fc24.src.rpm

PACKAGE APPROVED FOR FREE REPO

http://rpmfusion.org/Contributors#Your_package_gets_approved

But OpenAL still not work and disabled during configure.

I tried aegisub-3.2.2-1.fc23.src.rpm on fedora 25 (latest update from 2017/01/04), and it crashes when launched

A little bit of digging is that it's linked somehow to https://fedoraproject.org/wiki/Changes/WaylandByDefault

"GTK+ applications that use X11-specific APIs need to be patched to explicitly use the GDK X backend"

Actually, aegisub is not at fault. wxwidget (wxGTK3-3.0.2-30.fc25.src.rpm) expect to run on gtk with x11 backend (some hardcoded macro related to getting the current x11 display to use xv...). On my F25, the default gtk backend is now wayland (I ran my own aegisub on F24 without trouble.

And when running "GDK_BACKEND=x11 aegisub" there is no crashes

For me, the bug is in wxGTK3-3.0.2-30.fc25.src.rpm though. There is a few bugs on the subject upstream (http://trac.wxwidgets.org/search?q=wayland).

Also, any news as why the previous package didn't land on F24 yet ? aegisub is awesome and it would be great that everyone can enjoy it.

@michal, ffms2 is been imported, you should be able to import your package by then.
But first you need to create an account into our fas, you do not seems to have one already. (ideally using the same fedora fas account name).
Can you create it.
Thx

Nevermind, I've found your RPM Fusion fas name and have proceeded with the git module creation. Please import your package.
Thx

(In reply to Nicolas Chauvet from comment #14)

Thank you Nicolas, yes I was waiting for the ffms2. i will work on importing aegisub on weekend.
Mik

I have impoerted the package, but build fails on dependencied, when instlalling ffmpeg-libs

Error: from the build logs:
http://koji.rpmfusion.org/kojifiles/work/tasks/9448/89448/root.log
DEBUG util.py:439:  Error: nothing provides libbluray.so.1()(64bit) needed by ffmpeg-libs-3.2.4-1.fc26.x86_64

Hi Michal,

Sorry about that, this is more or less my fault.

2 days ago, I built latest version of libbluray for Rawhide and Fedora 26.
The update for Fedora 26 will be part of the gnome update that is going to happen next week, because gvfs depends on libbluray.

RPM Fusion still builds against Fedora 26, and the libbluray update has been added as a buildroot override as I was about to rebuild all packages that depend on libbluray, including ffmpeg.
However, there is an RPM Fusion mass rebuild coming for F26 both to match Fedora 26's rebuild for gcc 7, but also to enable ppc64, ppc64le and aarch64 in RPM Fusion. It was discussed and agreed on #rpmfusion to wait for the mass rebuild to happen, which should be real soon, rather than rebuild the affected packages.
I'll send a mail to rpmfusion-devel so everyone knows.

The aegisub F26 build will be taken care of by the mass rebuild.
Meanwhile, building for F25 and F24 should be OK.

Again, sorry for the inconveniences.

Regards,
Xavier

Hi Xavier,
no problem at at all, it is not anything urgent to me. I will try to rebuild in a week or two.
Mik

You won't have to resubmit, the mass rebuild will do it for you.

Regards,
Xavier