Bug 4321

Summary: Version Update
Product: Fedora Reporter: MrDave <MotionMrDave>
Component: motionAssignee: RPM Fusion system account <noreply>
Status: RESOLVED FIXED    
Severity: enhancement CC: emailtoflorian, leigh123linux, MotionMrDave, sergio
Priority: P1    
Version: unspecified   
Hardware: x86_64   
OS: GNU/Linux   
namespace:
Attachments: motionrpm.patch

Description MrDave 2016-11-01 04:36:50 CET
The web home indicated needs to be updated to https://motion-project.github.io/  

Version 4.0.1 has recently been released(https://github.com/Motion-Project/motion/releases).  Is it possible for you to update your repo with this new version or submit a issue to the project indicating needed steps.  

Thanks
Mr-Dave
Comment 1 Tomasz Torcz 2016-11-01 09:32:49 CET
I've orphaned this package - http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2015-January/017889.html

I'm not longer a maintainer of it.
Comment 2 Sérgio Basto 2016-11-02 01:28:17 CET
Cool we have one new official release of motion , I will see , but ATM I'm kind of busy, can take sometime . 
You are https://github.com/Mr-Dave/motion ?  (https://bugzilla.rpmfusion.org/show_bug.cgi?id=3460#c6 )

Hopefully we have maintain montion [1], also change the owner we may change the owner , I will do a cvs request. 

[1] 
http://koji.rpmfusion.org/koji/buildinfo?buildID=1436
Comment 3 Sérgio Basto 2016-11-02 01:31:40 CET
Package Change Request
======================
Package Name: motion
Owners: sergiomb leigh123linux
Branches: f23 f24 f25 el5 el6 epel7
InitialCC:
----------------------
License tag: free
Comment 4 MrDave 2016-11-02 02:15:08 CET
Yes, I am the Mr-Dave in the other bug.  The previous maintainer has passed it over to me and my repo which is now the official motion-project.  There is a spec file in the source but it is outdated and I want to get the new version out for RPM distros.  Once I know the policies for the RPMs and a validated new spec file I'll push that to the upstream.  

Whenever you get the time, just post to here or post a issue in the git issues if something needs to be fixed to allow for RPMs.

Mr-Dave
Comment 5 Sérgio Basto 2016-11-02 02:34:03 CET
if you send me a patch or a pull request from our motion.spec [1] , it would be great , if we want use pull request of github, after do the pull request ping here please, I may miss the notification ... .
Thanks.

[1] https://github.com/rpmfusion/motion/commits/master
Comment 6 Nicolas Chauvet 2016-11-02 09:23:27 CET
@Sérgio
I don't understand why you submit package change request when we have pkgdb2 ?
CVS request should only be done for new package until someone (probably me) figures out what need to be done for new package introduction in pkgdb2 directly.
Comment 7 Sérgio Basto 2016-11-02 21:56:27 CET
(In reply to Nicolas Chauvet from comment #6)
> @Sérgio
> I don't understand why you submit package change request when we have pkgdb2
> ?

it is working ? I'll will test it soon ...

> CVS request should only be done for new package until someone (probably me)
> figures out what need to be done for new package introduction in pkgdb2
> directly.

OK
Comment 8 Sérgio Basto 2016-11-03 02:23:35 CET
(In reply to Sérgio Basto from comment #7)
> (In reply to Nicolas Chauvet from comment #6)
> > @Sérgio
> > I don't understand why you submit package change request when we have pkgdb2
> > ?
> 
> it is working ? I'll will test it soon ...

in https://admin.rpmfusion.org/pkgdb/package/free/motion/ I got option "give package" , which I haven't in fedora pkgdb, should I give package to myself ?
can I add leigh123linux also ? 

Thanks.
Comment 9 leigh scott 2017-03-13 18:32:56 CET
(In reply to Sérgio Basto from comment #5)
> if you send me a patch or a pull request from our motion.spec [1] , it would
> be great , if we want use pull request of github, after do the pull request
> ping here please, I may miss the notification ... .
> Thanks.
> 
> [1] https://github.com/rpmfusion/motion/commits/master

Can you double check this commit to master please?

https://pkgs.rpmfusion.org/cgit/free/motion.git/commit/?id=d545e3e60715be5061aba301a71656cc0cdaa34d
Comment 10 Sérgio Basto 2017-03-14 00:18:59 CET
(In reply to leigh scott from comment #9)
> Can you double check this commit to master please?
> 
> https://pkgs.rpmfusion.org/cgit/free/motion.git/commit/
> ?id=d545e3e60715be5061aba301a71656cc0cdaa34d

Thanks Leigh, LGTM , but I haven't time to test it , maybe  MrDave.

--without-optimizecpu was already there , but is needed ?
Comment 11 MrDave 2017-03-14 03:43:59 CET
Created attachment 1752 [details]
motionrpm.patch
Comment 12 MrDave 2017-03-14 03:50:01 CET
I have not used rpms so I do not think that I can validate the accuracy of everything.  The following are comments from my review.

1.  The Motion configure uses pkgconfig for ffmpeg and it appears that the spec uses pkgconfig for sqlite3.  Do not know if this is an issue or not.

2.  I would recommend keeping the --without-optimizecpu it is the safest selection

3.  Sqlite3 is included so do not remove those options from the config

4.  Some of the default directories were revised in the directory.

5.  Revised the home page.
Comment 13 Sérgio Basto 2017-05-07 02:29:29 CEST
Patch applied [1] , it will be build  for rawhide and F26. 

Thanks.


[1] 
https://pkgs.rpmfusion.org/cgit/free/motion.git/commit/?id=7c7c847458b99bc500e39fd73d4b2cb4bb040931