| Summary: | openshot-lang does not include .qm files | ||
|---|---|---|---|
| Product: | Fedora | Reporter: | Massimo <mfs-it2> |
| Component: | openshot | Assignee: | Richard <hobbes1069> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | P1 | ||
| Version: | 24 | ||
| Hardware: | x86_64 | ||
| OS: | GNU/Linux | ||
| namespace: | |||
| Attachments: | Patch for openshot.spec | ||
I really don't understand how these work... Do we need the mo files as well? I went a slightly different route and just included a modified version of find-lang.sh as a source file and redefined $find_lang to use it. Seems to work well, I was able to set the LANG environment variable to French and it worked. I'm having a bit of a problem on the build system but will try to get new builds done soon. (In reply to Richard from comment #1) > I really don't understand how these work... Do we need the mo files as well? I don't think so (In reply to Richard from comment #2) > I went a slightly different route and just included a modified version of > find-lang.sh as a source file and redefined $find_lang to use it. What I proposed is borrowed from an old patch that had been used in similar circumstances in the past ( for example, here: https://bugzilla.redhat.com/show_bug.cgi?id=729336#c3 ) Obviously any approach is good if effective; dealing with this issue creating a file separated from the spec seems nice too. For reference, the upstream has a copy of this bugreport and so it may become aware of this issue ( https://github.com/OpenShot/openshot-qt/issues/418 ). If we have a separate patch to fix it in the mewanwhile, it may be easier to adapt to future upstream corrections * Sun Dec 04 2016 Richard Shaw <hobbes1069@gmail.com> - 2.1.0-2 - All translation files now included in openshot-lang, fixes RFBZ#4358. - Change dependency on openshot-lang from Requires to Recommends. |
Created attachment 1699 [details] Patch for openshot.spec The package openshot-lang includes only .mo files. For openshot-qt to be translated we need .qm files. The nomenclature of the .qm files used by upstream is non-standard, therefore /usr/lib/rpm/find-lang.sh won't find .qm files even if we use the "--all-name --with-qt" switches. A patch loosely based on /usr/lib/rpm/find-lang.sh is used to find these .qm files having a nomenclature similar to .mo ones.