| Summary: | Review request: qt5-qtwebengine-freeworld - Qt5 - QtWebEngine components (freeworld version) | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Kevin Kofler <kevin.kofler> |
| Component: | Review Request | Assignee: | Rex Dieter <rdieter> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | rdieter, rpmfusion-package-review |
| Priority: | P1 | ||
| Version: | Current | ||
| Hardware: | x86_64 | ||
| OS: | GNU/Linux | ||
| URL: | http://koji.rpmfusion.org/koji/taskinfo?taskID=57930 | ||
| namespace: | |||
| Bug Depends on: | |||
| Bug Blocks: | 4 | ||
|
Description
Kevin Kofler
2016-12-05 16:56:03 CET
I reviewed the fedora package, will do so here too. naming: ok
licensing: ok (but complicated, thoroughly vetted in related fedora reviews)
macros: ok
sources: not ok?
from src.rpm:
d682226dbb6c0188e20e12b6d63dab80 qtwebengine-opensource-src-5.7.1.tar.xz
from referenced snapshots url:
c90fba515fb33c091904fe2cadbb345a qtwebengine-opensource-src-5.7.1.tar.xz
1. MUST use verifiable sources, can you account for this difference? (maybe used a different snapshot?)
builds/installs: ok
runtime not tested (qt-5.7.1 available only for rawhide a the moment)
2. SHOULD confirm qtbase dependency
%{?_qt5_version:Requires: qt5-qtbase%{?_isa} >= %{_qt5_version}}
for the fedora package we currently use a tighter,
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
(but not a big deal, since this package also depends on the fedora base qt5-qtwebengine package...)
3. SHOULD consider using -debuginfo shrinking hacks on all archs (including x86_64)
APPROVED
please address item 1 prior to import, not treating as strict blocker since we're dealing with snapshots.
> APPROVED Thanks! That was quick. Can you please set the fedora-review+ flag? > 1. MUST use verifiable sources, can you account for this difference? (maybe used a different snapshot?) Looks like Qt upstream respun all its tarballs on: http://download.qt.io/snapshots/qt/5.7/5.7.1/latest_src/submodules/ on December 5. I will update to the latest tarball on import. But the Qt 5.7.1 packages in Fedora (including QtWebEngine) need updating too. > builds/installs: ok > > runtime not tested (qt-5.7.1 available only for rawhide a the moment) I'll have a try in a VM (downloading some Rawhide ISOs now, but it takes some time), but I don't expect nasty surprises, this uses the same trick as freetype-freeworld. > 2. SHOULD confirm qtbase dependency > %{?_qt5_version:Requires: qt5-qtbase%{?_isa} >= %{_qt5_version}} > > for the fedora package we currently use a tighter, > %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} This is actually one of the many lines copies as is from the current Fedora Rawhide package: http://pkgs.fedoraproject.org/cgit/rpms/qt5-qtwebengine.git/tree/qt5-qtwebengine.spec#n277 I should probably fix the >= to > in both packages. > 3. SHOULD consider using -debuginfo shrinking hacks on all archs (including x86_64) Well, we had this discussion already. :-) This is really a tradeoff between quality and size of debugging information. On 32-bit architectures, we have no other option than using -g1 because the linker will run out of address space with -g. On x86_64, we have no such issue. setting fedora-review flag to X (not sure what that means, there doesn't seem to be a + setting that matches fedora's workflow) Package CVS request ====================== Package Name: qt5-qtwebengine-freeworld Short Description: Qt5 - QtWebEngine components (freeworld version) Owners: kkofler rdieter Branches: f25 f24 f23 InitialCC: ---------------------- License tag: free (In reply to Rex Dieter from comment #4) > setting fedora-review flag to X (not sure what that means, there doesn't > seem to be a + setting that matches fedora's workflow) Thx for report. Fixed that, so rpmfusion_contrib group (people with FAS account/email) can use this flag. This is not yet working, but will be checked by pkgdb for new package process... You still need to proceed according to the Contributors howto. I filled in the pkgdb form now, but that offers neither f24 nor f23 branches. OK, f23 is almost dead and Fedora does not allow new packages to be branched for f23, but why is f24 not offered? > runtime not tested (qt-5.7.1 available only for rawhide a the moment) I did that now: http://i.imgur.com/BC7HzMC.png :-) As explained on IRC, I tried not only https://www.youtube.com/html5 , but also an actual H.264-only video (from Twitter) that I was unable to watch with QupZilla before and that worked, too. (I had to test on the Rawhide Xfce Live because the KDE Live has not been composing for a few days.) (Sorry for yet another post, but I forgot something important:) Just a note of warning: If you want to try out qt5-qtwebengine-freeworld, you will have to close any running QupZilla instances (from before you installed the package) and start a new one. Starting a new QupZilla instance next to one that was already running before installing the package is not sufficient, because it will reuse processes and thus spawn even the new render processes with the wrong libraries. If you close all QupZilla instances completely and start a new one, it works. (If in doubt, just restart the whole session.) This problem is of course only a one-time problem when initially installing the package. Once you have the package, it becomes a non-issue. Built on all branches. |
