Bug 44

Summary:	Review Request: cryptopp - Free C++ class library of cryptographic schemes
Product:	Package Reviews	Reporter:	Nicolas Chauvet <kwizart>
Component:	Review Request	Assignee:	RPM Fusion Package Review <rpmfusion-package-review>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	opensource
Priority:	P5
Version:	Current
Hardware:	All
OS:	GNU/Linux
namespace:

Description Nicolas Chauvet 2008-09-17 14:46:59 CEST

Despite the License claims this code is in Public Domain
mars.cpp bundles code patented by IBM

There is a problem while building this package on i386 that nees to have -DCRYPTOPP_DISABLE_SSE2. (or removes -fPIC but using -fPIC is desirable for a shared built). It could be possible to have this options inherited as the CFLAGS for building the dependencies on i386.

SRPMS:
http://rpms.kwizart.net/fedora/testing/9/SRPMS/cryptopp-5.5.2-3.fc9.kwizart.src.rpm
SPECS:
http://rpms.kwizart.net/fedora/reviews/cryptopp/cryptopp.spec
Description: Free C++ class library of cryptographic schemes

Comment 1 Dominik 'Rathann' Mierzejewski 2008-09-17 16:32:13 CEST

FWIW you can try building this twice during the build process, once with SSE2, once without and putting sse2-enabled libs into %{_libdir}/sse2. The linker will find the appropriate version for your CPU automatically. See for example atlas package in Fedora.

Comment 2 Nicolas Chauvet 2008-09-17 17:02:24 CEST

That's an interesting case for sse2 and atlas. But clearly i do not plan to have this feature enabled in this case.
There no reason to have sse2 enabled on i386 since we need to make a choice between -fPIC and sse2. and using Position independant code will be better on x86 for a "big" shared library and it will be possible to use prelink on it (whereas it isn't with nonpic library).
Furthermore, dependencies building will not fail with "trying to link against x86_32 code, needs to recompile with -fPIC."

Testing case for this package was amule (tested on x86 and x86_64).
But was only tested at buildtime. Test at runtime would be nice.

According to http://en.wikipedia.org/wiki/X86-64
Every x86_64 cpu have sse2 already. so it doesn't worth the case to disable it.

Package also built fine on ppc ppc64

Comment 3 Till Maas 2008-09-30 09:51:49 CEST

FYI: There is a review request for this at Fedora's Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=462104

If this package is not suited for Fedora, please explain why.

Comment 4 Nicolas Chauvet 2008-09-30 10:20:00 CEST

>Despite the License claims this code is in Public Domain
>mars.cpp bundles code >>patented<<< by IBM
That been said the fedora version have the problematic code removed (by a patch)
if usability of dependent application can be proved, I will close this review request. Until then, the review is in waiting...

Comment 5 Nicolas Chauvet 2008-10-27 21:35:48 CET

Package has been approved in Fedora.
closing this bug as won't fix