Bug 4420

Summary: infrared remote support missing
Product: Fedora Reporter: bernard.godard
Component: vlcAssignee: Nicolas Chauvet <kwizart>
Status: RESOLVED FIXED    
Severity: enhancement CC: bernard.godard, leigh123linux
Priority: P1    
Version: 25   
Hardware: x86_64   
OS: GNU/Linux   
namespace:
Attachments: lirc patch

Description bernard.godard 2017-01-15 18:26:56 CET
It seems vlc for Fedora 25 in RPM Fusion is built without LIRC (infrared remote control) support.
Comment 1 Nicolas Chauvet 2017-01-15 18:42:41 CET
Our build.log says it is:
[...]
checking lirc/lirc_client.h usability... yes
checking lirc/lirc_client.h presence... yes
checking for lirc/lirc_client.h... yes
checking for lirc_init in -llirc_client... yes
[...]
http://koji.rpmfusion.org/kojifiles/packages/vlc/3.0.0/0.14.fc25/data/logs/x86_64/build.log

Can you verify where your package comes from ? (namely do you have any others repos outside Fedora + RPM Fusion).
Comment 2 Nicolas Chauvet 2017-01-15 19:36:03 CET
That been said, there is no liblirc.so.0 dependency from vlc or vlc-core.
So something might be broken in vlc upstream.
Comment 3 leigh scott 2017-01-16 02:46:57 CET
Created attachment 1726 [details]
lirc patch

(In reply to Nicolas Chauvet from comment #2)
> That been said, there is no liblirc.so.0 dependency from vlc or vlc-core.
> So something might be broken in vlc upstream.

HAVE_LIRC doesn't get defined in config.h, removing the check on the make file fixes missing support


$ rpm -qp --requires /home/leigh/development/rpmbuild/RPMS/x86_64/vlc-core-3.0.0-0.14.fc26.x86_64.rpm |grep lirc
liblirc_client.so.0()(64bit)
Comment 4 Nicolas Chauvet 2017-01-16 22:27:07 CET
Can you test this build (clean patch)
http://koji.rpmfusion.org/koji/taskinfo?taskID=72574
Comment 5 bernard.godard 2017-01-18 09:34:36 CET
With this new build, I can use my infrared remote fine.

Thank you
Comment 6 Nicolas Chauvet 2017-02-12 12:34:46 CET
patch merged upstream.