Bug 4572

Summary: chromium-libs-media-freeworld doesn't check for needed chromium package
Product: Package Reviews Reporter: timewulf
Component: Review RequestAssignee: Miro Hrončok <mhroncok>
Status: RESOLVED FIXED    
Severity: enhancement CC: leigh123linux, rpmfusion-package-review
Priority: P1    
Version: Current   
Hardware: x86_64   
OS: GNU/Linux   
namespace: free

Description timewulf 2017-06-23 13:46:46 CEST
When installing chromium-libs-media-freeworld-59.0.xxxx, this doesn't check for an available chromium-59.0.xxxx package.

Instead it uninstalls chromium-58.x.xxxx what definitely noone wants.
Comment 1 Kevin Kofler 2017-06-24 10:24:52 CEST
I guess there should be a version-locked Requires on chromium in chromium-libs-media-freeworld.
Comment 2 Nicolas Chauvet 2017-06-24 10:42:47 CEST
(In reply to Kevin Kofler from comment #1)
> I guess there should be a version-locked Requires on chromium in
> chromium-libs-media-freeworld.

I think it's the other way. The fedora chromium package should relax the requires on -libs-media so we don't need to rebuilt the package for every issue that affect the fedora package once the version is the same.
Comment 3 timewulf 2017-06-24 11:03:54 CEST
(In reply to Nicolas Chauvet from comment #2)
> (In reply to Kevin Kofler from comment #1)
> > I guess there should be a version-locked Requires on chromium in
> > chromium-libs-media-freeworld.
> 
> I think it's the other way. The fedora chromium package should relax the
> requires on -libs-media so we don't need to rebuilt the package for every
> issue that affect the fedora package once the version is the same.

In general you may be right, but here it seems to be a bit special:
This package has changed to major version 59, but chromium and all its depending packages is still at 58.

Maybe, it's worth to start some synchronizing here.

We should take the chromium package maintainers into this discussion, too.
Comment 4 timewulf 2017-06-24 11:18:34 CEST
What about using rpmfusion-update and rpmfusion-update-testing in the recommended way?

The "old" version (here 58.x.xxxx) stays in rpmfusion-update until the new packages (59.x.xxxx) are synchronized and correctly working in rpmfusion-update-testing. Thereafter the old will be replaced by the new for starting to work on the next changes in rpmfusion-update-testing?

The problem I see is, that both teams don't use the testing repository to synchronize there work.
Comment 5 Nicolas Chauvet 2017-06-24 11:19:04 CEST
https://koji.fedoraproject.org/koji/packageinfo?packageID=22672
Still the problem remains, chromium has to kick out EVR on -libs-media.

Packages will be pushed in the afternoon.
Comment 6 timewulf 2017-06-27 09:18:09 CEST
(In reply to Nicolas Chauvet from comment #5)
> https://koji.fedoraproject.org/koji/packageinfo?packageID=22672
> Still the problem remains, chromium has to kick out EVR on -libs-media.
> 
> Packages will be pushed in the afternoon.


Chromium-59.x.xxxx is in updates now and the update queue is working again.

For this special version this bug is solved. Shall it stay open for working on the general problem?
Comment 7 Miro Hrončok 2017-06-27 12:34:52 CEST
(In reply to timewulf from comment #6)
> For this special version this bug is solved. Shall it stay open for working
> on the general problem?

Yes please.
Comment 8 timewulf 2017-07-12 14:01:37 CEST
same problem again for actual package version

Why not trying my proposal (see comment #4)?

You could hold back the new version in testing until Chromium itself is available in updates ...

But now again, the default update procedure doesn't work for most users of this library ...
Comment 9 Miro Hrončok 2017-07-12 15:24:36 CEST
I've built it in Koji as soon as I've seen it in Fedora Koji. Unfortunatelly, in Fedora it never git to Bodhi, in RPMFusion, it moved on without my doing :(

Next time, I'll build it once in Bodhi.
Comment 10 Nicolas Chauvet 2017-07-12 16:53:24 CEST
(In reply to Miro Hrončok from comment #9)
> I've built it in Koji as soon as I've seen it in Fedora Koji.
> Unfortunatelly, in Fedora it never git to Bodhi, in RPMFusion, it moved on
> without my doing :(
You mean you haven't done anything to prevent it ?

I think you should have acl to fedora chromium in the first step, so you can have hands on what's going on there and create update, etc.

Then, there is a need to adapt the rpmfusion push script to check which chromium version is where...
Once should manager to do something with koji/koji-rpmfusion

I will try to publish the push script, so one can update it.

The last item is do we have resources to migrate to bodhi ?
Comment 11 Miro Hrončok 2017-07-12 17:59:43 CEST
(In reply to Nicolas Chauvet from comment #10)
> The last item is do we have resources to migrate to bodhi ?

I don't think so :(
Comment 12 Miro Hrončok 2017-09-01 11:54:56 CEST
I think adding:

Requires: chromium%{?_isa} == %{version}-%{release}

should fix the original problem.

It does not solve the situation when the version are out of sync, but at least it should not remove chromioum, just like reported.
Comment 14 Nicolas Chauvet 2017-12-06 13:42:15 CET
I think the issue is solved nowadays. Please re-open if it's not the case.

FYI I've removed an old chromium-libs-media-freeworld before the rename from the f27 GA repo.