| Summary: | Review Request: openmotif - Open Motif runtime libraries and executables | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | Jochen Schmitt <Jochen> |
| Component: | Review Request | Assignee: | Rex Dieter <rdieter> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dtimms, hans, jameshubbard, jfrieben, kanarip, mail, rdieter, rpmfusion-package-review, solarflow99, supercyper1 |
| Priority: | P5 | ||
| Version: | Current | ||
| Hardware: | All | ||
| OS: | GNU/Linux | ||
| namespace: | |||
| Bug Depends on: | |||
| Bug Blocks: | 4 | ||
| Attachments: | rpmlint output | ||
|
Description
Jochen Schmitt
2009-03-26 19:49:03 CET
I have reorganized the file layout. The libraries are moved into %{_libdir}/openmotif/lib and the header files are moved to %{_includedir}/openmotif.
The new release is uploaded at:
SPEC: http://www.herr-schmitt.de/pub/openmotif/openmotif.spec
SRPM: http://www.herr-schmitt.de/pub/openmotif/openmotif-2.3.2-1.fc10.src.rpm
Created attachment 140 [details]
rpmlint output
It seems there's a bunch of -devel files in %{_libdir}/Xm/ still, belonging to the openmotif-demos package. A full rpmlint output is attached
I know, that rpmlint has complaints about the demo package. This happens because the demos which are located on %{_libdir}/Xm contains c header files. But I think this is acceptable. Moving to %{_datadir} is not an option, because the demo package contains runable binaries of the demos.
(In reply to comment #3) > I know, that rpmlint has complaints about the demo package. This happens > because the demos which are located on %{_libdir}/Xm contains c header files. > But I think this is acceptable. Moving to %{_datadir} is not an option, because > the demo package contains runable binaries of the demos. > # rpmlint openmotif* openmotif.src: W: invalid-license Open Group Public License 1 packages and 1 specfiles checked; 0 errors, 1 warnings. Looking at the spec file, I just noticed this very minor error: # SMP build doesn't works make # %{?_smp_mflags} should be work, not works right? There are 2 makes, but I assume you know what you are doing here. (In reply to comment #4) > # rpmlint openmotif* > openmotif.src: W: invalid-license Open Group Public License > 1 packages and 1 specfiles checked; 0 errors, 1 warnings. Rpmlint doesn't know this license because this is not a free license. That is the reason why openmotif should go into rpmfusion.non-free. > Looking at the spec file, I just noticed this very minor error: > # SMP build doesn't works > make # %{?_smp_mflags} I have try out a SMP build, but it's failed on my system. Best Regards: Jochen Schmitt openmotif-clients requires openmotif = %{version}-%{version} rather then openmotif = %{version}-%{release}
openmotif-mwm requires openmotif-%{version} rather then openmotif = %{version}-%{release}
While I'm at this, it seems the man-pages of openmotif-devel and lesstif-devel conflict. Sorry for using this bug as a notepad tracking what else needs to be done as I go along with this BTW - I know it causes some spam for some of you :/ == file /usr/share/man/man3/ApplicationShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/Composite.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/Constraint.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/Core.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/Object.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/OverrideShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/Shell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/TopLevelShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/TransientShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/VendorShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmArrowButton.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmArrowButtonGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmBulletinBoard.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmCascadeButton.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmCascadeButtonGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmComboBox.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmCommand.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDialogShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDisplay.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDragContext.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDragIcon.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDrawingArea.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDrawnButton.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmDropTransfer.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmFileSelectionBox.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmForm.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmFrame.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmIconGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmLabel.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmLabelGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmList.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmMainWindow.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmManager.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmMenuShell.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmMessageBox.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmNotebook.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmPanedWindow.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmPrimitive.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmPushButton.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmPushButtonGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmRowColumn.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmScale.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmScreen.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmScrollBar.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmScrolledWindow.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmSelectionBox.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmSeparator.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmSeparatorGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmSpinBox.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmString.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmText.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmTextField.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmToggleButton.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 file /usr/share/man/man3/XmToggleButtonGadget.3.gz from install of openmotif-devel-2.3.2-2.fc10.i386 conflicts with file from package lesstif-devel-0.95.0-26.fc10.i386 == I now use this spec, maybe it's helpful: http://www.kanarip.com/custom/SPECS/openmotif.spec New release: SPEC: http://www.herr-schmitt.de/pub/openmotif/openmotif.spec SRPM: http://www.herr-schmitt.de/pub/openmotif/openmotif-2.3.2-3.fc10.src.rpm Ping Jeroen Works wonderfully now: $ rpm -qv lesstif-devel openmotif-devel lesstif-devel-0.95.0-28.fc11.x86_64 openmotif-devel-2.3.2-3.fc11.x86_64 Ping Jeroen It may be nice, if you can do a formal review and approvement for this package. I'm not an approved packager in RPMFusion let alone a reviewer. Can I still do a formal review under these circumstances? (In reply to comment #14) > I'm not an approved packager in RPMFusion let alone a reviewer. Can I still do > a formal review under these circumstances? You are an approved packager in Fedora and thus also in RPMFusion. Packagers are allowed to (and should!) perform reviews both in Fedora and RPMFusion. (In reply to comment #15) > (In reply to comment #14) > > I'm not an approved packager in RPMFusion let alone a reviewer. Can I still do > > a formal review under these circumstances? > > You are an approved packager in Fedora and thus also in RPMFusion. Packagers > are allowed to (and should!) perform reviews both in Fedora and RPMFusion. > Yet I can't set any flags or assign the bug to myself. (In reply to comment #16) > Yet I can't set any flags or assign the bug to myself. Not sure about that, but you can still participate while that gets sorted: did you sign up for an RPM Fusion fas account http://rpmfusion.org/Contributors In any case you can still do pre-reviews, that can turn into a full review once the account side is sorted. The Fedora - RPM Fusion equivalency is not automatic, and I think is usually requested in the rpmfusion-developers@lists.rpmfusion.org As you are placing the libraries in /usr/lib/openmotif/lib but not defining the subdir within the %files section, it won't be removed during un-install process. I am also not sure if it really makes sense to create: /usr/lib/openmotif/lib instead of placing the libs directly into: /usr/lib/openmotif in this case. Best Regards Marcus Next release: SPEC: http://www.herr-schmitt.de/pub/openmotif/openmotif.spec SRPM: http://www.herr-schmitt.de/pub/openmotif/openmotif-2.3.2-4.fc11.src.rpm I can help review this. upstream source verified: $ md5sum *.gz bf5479d52bc114d299200ec20e463e96 openmotif-2.3.2.tar.gz macro usage good, consistent. functionality: tested a few items from openmotif-demos scriptlets: OK Conflicts all look legit, needed. SHOULD: drop Requires: /usr/share/X11/XKeysymDB this is owned by libX11, and already pulled in implicitly via many of the existing libX* deps of openmotif. I won't consider this a review-blocker, I'd prefer if it were removed prior to deploying in rpmfusion. Otherwise, looks like we have a winner, APPROVED. Package CVS request ====================== Package Name: openmotif Short Description: Open Motif runtime libraries and executables Owners: s4504kr Branches: F-11, F-10 InitialCC: ---------------------- License tag: free (In reply to comment #22) > License tag: free Sorry, it should be nonfree. branched in CVS; sorry for the delay /me hopes to find some time to write a more detailed mail regarding "how to make sure CVS branch request happen more quickly in the future" to the list on Sunday afternoon or at the end of next week I've been rebuilding the openmotif src.rpms from the fc5 release for some software that I have to use. I picked up these new packages today by accident when doing an update. I was glad to see that someone had decided to package these until I ran into problems with some software that I use. After getting the update, the software wouldn't compile or link. This is due to moving the openmotif development files. The application's configure scripts look for the motif files in /usr/include/Xm/. I think that there will be others complaining because the libs have been moved to a new location. Hopefully there aren't that many that are forced to use openmotif. The software that I use relies on openmotif. Lesstif isn't appropriate. It causes problems with the software. I can understand the desire to not overwrite the lesstif files. If someone wants the openmotif libs, he/she probably doesn't care about losing the lesstif files. RHEL (4.x, 5.x) and Ubuntu have openmotif libraries. They place them in the /usr/include/Xm/ and /usr/lib. By changing the location, this will create a hardship for those that expect the files in the traditional locations. (In reply to comment #25)> look for the motif files in /usr/include/Xm/. I think that there will be > others complaining because the libs have been moved to a new location. > Hopefully there aren't that many that are forced to use openmotif. > The software that I use relies on openmotif. Lesstif isn't appropriate. It > causes problems with the software. I can understand the desire to not overwrite > the lesstif files. If someone wants the openmotif libs, he/she probably doesn't > care about losing the lesstif files. > RHEL (4.x, 5.x) and Ubuntu have openmotif libraries. They place them in the > /usr/include/Xm/ and /usr/lib. By changing the location, this will create a > hardship for those that expect the files in the traditional locations. Ths issue is, that lesstif puts their files on /usr/include and /usr/lib(64), so I have put the files on /usr/include/openmotif and /usr/lib(64)/openmotif to avoid a packaging comflict agains lesstif. You chould try to specified thhis path on you configure script. If this should not works, you may contact me vis email. I know that it lesstif puts their files in those places. Ideally, when someone installs openmotif, it would uninstall lesstif. I've already looked at the configure script. It does not allow someone to change the location of where it's looking for the openmotif. There's a lot of tradition to that location. I don't have the power to change the configure script either. If you have to place the files in openmotif, I understand. You have to follow the packaging guidelines. However, I will have to exclude the openmotif packages from the repo and continue to build my own. Choosing non-standard paths for installing header files and libraries is a bad idea. For this reason package ddd-3.3.12-5.fc14 fails to build against openmotif-devel-2.3.3-1.fc14.x86_64.rpm whereas it builds correctly against openmotif-devel-2.3.3-1.el6.x86_64 once the lesstif dependency in the spec file has been altered. The package origanization chosen by Red Hat for its EL package should be considered authoritative in this case. Header files are simply located in directory /usr/include. Accordingly, ddd-3.3.12-5.fc14 builds without a hitch. I strongly suggest to simply adopt Red Hat's source package for this repository. It cannot, else it would conflict with fedora's lesstif package. (In reply to comment #28) > Choosing non-standard paths for installing header files and libraries is a bad > idea. For this reason package ddd-3.3.12-5.fc14 fails to build against > openmotif-devel-2.3.3-1.fc14.x86_64.rpm whereas it builds correctly against > openmotif-devel-2.3.3-1.el6.x86_64 once the lesstif dependency in the spec file > has been altered. > The package origanization chosen by Red Hat for its EL package should be > considered authoritative in this case. Header files are simply located in > directory /usr/include. Accordingly, ddd-3.3.12-5.fc14 builds without a hitch. > We (rpmfusion) have a very strong policy not to create packages which conflict with packages already in Fedora. Thus we must put the .so devel symlinks and headers in a different place. Yes this means that if you want to compile something against openmotif you will need to somehow tell the buildsystem of the something where to look for the headers and libs, this is unavoidable when packaging 2 competing implementations of 1 API. See fedora policy for conflict files: Library Name Conflicts Put the library in a subdirectory of /usr/lib or /lib and include a ld.so.conf file in /etc/ld.so.conf.d/. Header Name Conflicts Put the headers in a subdirectory of /usr/include. http://fedoraproject.org/wiki/Packaging/Conflicts#Library_Name_Conflicts The best solution would actually be to remove lesstif from the Fedora package pool, because not only it is dead but its latest incarnation 0.95.2 from May 2009 is badly broken, too (even for basic applications like nedit), and to move all Motif dependent packages to rpmfusion where they could be built against the proper package, namely openmotif. This would also solve the problem related to the header/library paths. offtopic here certainly, rpmfusion isn't in a position to elicit change in fedora. Just noticed this still open, I think we can close this now. thanks everyone. |