Bug 5022

Summary: Review Request: wireguard - Fast, modern, secure VPN tunnel
Product: Package Reviews Reporter: Robert-André Mauchin <zebob.m>
Component: Review RequestAssignee: Nicolas Chauvet <kwizart>
Status: RESOLVED FIXED    
Severity: enhancement CC: rpmfusion-package-review
Priority: P1 Flags: kwizart: fedora-review+
Version: Current   
Hardware: x86_64   
OS: GNU/Linux   
namespace: free

Description Robert-André Mauchin 2018-09-13 22:00:44 CEST 
SPEC url: https://eclipseo.fedorapeople.org/wireguard/wireguard.spec
SRPM url: https://eclipseo.fedorapeople.org/wireguard/wireguard-0.0.20180910-1.fc30.src.rpm

Koji scratch-build: F30: http://koji.rpmfusion.org/koji/taskinfo?taskID=258182
                    EL7: http://koji.rpmfusion.org/koji/taskinfo?taskID=258162


Description:
WireGuard is a novel VPN that runs inside the Linux Kernel and utilizes 
state-of-the-art cryptography. It aims to be faster, simpler, leaner, 
and more useful than IPSec, while avoiding the massive headache. It intends 
to be considerably more performant than OpenVPN. WireGuard is designed as a 
general purpose VPN for running on embedded interfaces and super computers 
alike, fit for many different circumstances. It runs over UDP.


FAS username: eclipseo

Why this package is not eligible to be included in Fedora.?
It's the kmod common package.

RPMlint output:

$ rpmlint wireguard-0.0.20180910-1.fc28.noarch.rpm wireguard-0.0.20180910-1.fc28.src.rpm
wireguard.noarch: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
wireguard.noarch: W: no-documentation
wireguard.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
2 packages and 0 specfiles checked; 0 errors, 3 warnings.


The Wireguard packages have been tested successfully on F28 with Mullvad VPN service.
Comment 1 Robert-André Mauchin 2018-09-14 15:40:26 CEST 
SPEC url: https://eclipseo.fedorapeople.org/wireguard/wireguard.spec
SRPM url: https://eclipseo.fedorapeople.org/wireguard/wireguard-0.0.20180910-1.fc30.src.rpm

Koji scratch-build: F30: http://koji.rpmfusion.org/koji/taskinfo?taskID=258276


Description:
WireGuard is a novel VPN that runs inside the Linux Kernel and utilizes 
state-of-the-art cryptography. It aims to be faster, simpler, leaner, 
and more useful than IPSec, while avoiding the massive headache. It intends 
to be considerably more performant than OpenVPN. WireGuard is designed as a 
general purpose VPN for running on embedded interfaces and super computers 
alike, fit for many different circumstances. It runs over UDP.


FAS username: eclipseo

Why this package is not eligible to be included in Fedora.?
It's the kmod common package.

RPMlint output:
$ rpmlint wireguard-0.0.20180910-1.fc28.src.rpm wireguard-0.0.20180910-1.fc28.x86_64.rpm wireguard-debuginfo-0.0.20180910-1.fc28.x86_64.rpm wireguard-debugsource-0.0.20180910-1.fc28.x86_64.rpm 
wireguard.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
wireguard.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
4 packages and 0 specfiles checked; 0 errors, 2 warnings.


I have merged tools and fixed the URL.
Comment 2 Nicolas Chauvet 2018-09-21 15:48:17 CEST 
Good,
Please just consider adding make V=1 to have verbose build
(which show the fedora cflags are used).

The package is APPROVED by me