Bug 5104

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/glmixer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/glmixer-1.7.1839-1.fc29.src.rpm

%changelog
* Sat Dec 08 2018 Martin Gansser <martinkg@fedoraproject.org> - 1.7.1839-1
- Update to 1.7.1839-1
- Add appdata.xml

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/glmixer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/glmixer-1.7.1840-1.fc29.src.rpm


%changelog
* Mon Dec 10 2018 Martin Gansser <martinkg@fedoraproject.org> - 1.7.1840-1
- Update to 1.7.1840
- Dropped glmixer-glew-sys.patch

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/glmixer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/glmixer-1.7.1875-1.fc29.src.rpm

%changelog
* Fri Jan 04 2019 Martin Gansser <martinkg@fedoraproject.org> - 1.7.1875-1
- Update to 1.7.1875

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/glmixer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/glmixer-1.7.1914-1.fc30.src.rpm


%changelog
* Fri May 17 2019 Martin Gansser <martinkg@fedoraproject.org> - 1.7.1914-1
- Update to 1.7.1914

I will review.

1. Instead
%setup -qn GLMixer-%{version}-Source
%patch0 -p1

use
%autosetup -p1 -n GLMixer-%{version}-Source

2. Add 
Requires:       hicolor-icon-theme

3. Change
%{_libdir}/%{name}/libffgl*.so

to
%{_libdir}/%{name}

4. It can be builded with Qt5?

(In reply to Vasiliy Glazov from comment #6)
> 1. Instead
> %setup -qn GLMixer-%{version}-Source
> %patch0 -p1
> 
> use
> %autosetup -p1 -n GLMixer-%{version}-Source
> 
> 2. Add 
> Requires:       hicolor-icon-theme
> 
> 3. Change
> %{_libdir}/%{name}/libffgl*.so
> 
> to
> %{_libdir}/%{name}
> 
> 4. It can be builded with Qt5?

will upload a new package, but the source code requires qt4

BUILDSTDERR: CMake Error at /usr/share/cmake/Modules/FindQt4.cmake:1314 (message):
BUILDSTDERR:   Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/glmixer.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/glmixer-1.7.1914-2.fc30.src.rpm


%changelog
* Fri May 17 2019 Martin Gansser <martinkg@fedoraproject.org> - 1.7.1914-2
- Use macro %%autosetup
- Add RR hicolor-icon-theme
- Use %%{_libdir}/%%{name}

> but the source code requires qt4

Qt4 is deprecated and no longer supported by upstream. You should avoid it because it has lots of known major issues.

Please ask upstream to switch to Qt5.

(In reply to Vitaly Zaitsev from comment #9)
> > but the source code requires qt4
> 
> Qt4 is deprecated and no longer supported by upstream. You should avoid it
> because it has lots of known major issues.
> 
> Please ask upstream to switch to Qt5.


have opened upstream ticket [1]

[1] https://sourceforge.net/p/glmixer/tickets/94/

I don't think glmixer is active upstream anymore.
Do we want to follow the review or not ? (specially as it will be still using qt4).

@Martin
I'm suggesting to close, but if you want to continue, please re-open.

(In reply to Nicolas Chauvet from comment #11)
> I don't think glmixer is active upstream anymore.

?? There were 57 commits[1] to its repo in 2019, the most recent were a bunch all on 2019-11-03 and 2019-11-04.

I have no opinion on its UTILITY or whatever, and I have no idea whether they plan to modernize the code, but that doesn't strike me as a dead project.

(Though I agree that, unless they're planning to migrate to Qt5, it seems kind of pointless. And the fact that there was no response to Martin's Qt5 request ticket is a bad sign.)

[1]: https://sourceforge.net/p/glmixer/Source/commit_browser