| Summary: | Review Request: mpc-qt - A clone of Media Player Classic reimplemented in Qt | ||
|---|---|---|---|
| Product: | Package Reviews | Reporter: | leigh scott <leigh123linux> |
| Component: | Review Request | Assignee: | Vasiliy Glazov <vascom2> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | akarshan.biswas, rpmfusion-package-review, vascom2 |
| Priority: | P1 | Flags: | vascom2:
fedora-review+
|
| Version: | Current | ||
| Hardware: | x86_64 | ||
| OS: | GNU/Linux | ||
| namespace: | free | ||
|
Description
leigh scott
2019-06-01 10:33:32 CEST
1. Change license to GPLv2+. 2. In %files section license file must be in %license LICENSE not in %doc. Are you shure that you want add to repo project with last commit almost a year ago? (In reply to Vasiliy Glazov from comment #1) > 1. Change license to GPLv2+. > > 2. In %files section license file must be in > %license LICENSE > not in %doc. > 1 and 2 have been fixed > Are you shure that you want add to repo project with last commit almost a > year ago? Yes Approved. I might be wrong but I find no mention appdata either in the spec file or in the source rpm. Isn't supposed to add an appdata file to for a GUI application make it discover able in GUI software managers as a rule? Cheers, Akarshan Biswas https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ If a package contains a GUI application, then it SHOULD install a .appdata.xml file into %{_metainfodir}. (In reply to Vasiliy Glazov from comment #5) > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > > If a package contains a GUI application, then it SHOULD install a > .appdata.xml file into %{_metainfodir}. Exactly, I don't see any reference of %{metainfodir} in the %file section. Though I admit I haven't checked the source archive. An appdata file required before this package can be approved because mpc-qt is one of the GUI frontend for mpv written in Qt similar to gnome-mpv. Cheers, Akarshan Biswas Pronouns: He/Him/His TZ=Asia/Kolkata It is not mandatory. As I see mpc-qt - not frontend to mpv like smplayer or gnome-mpv. Ut just use mpv-libs to play video. (In reply to Vasiliy Glazov from comment #8) > As I see mpc-qt - not frontend to mpv like smplayer or gnome-mpv. Ut just > use mpv-libs to play video. It's a GUI frontend for mpv. Qt is an alternative toolkit like GTK. Please see: https://github.com/mpv-player/mpv/wiki/Applications-using-mpv (In reply to Vasiliy Glazov from comment #3) > Approved. Thanks for the review can you set the + flag so I can process the request please? Fedora-review flag not approved @vascom2 When your ready for the gnome-mpv rereview needed for the rename https://github.com/celluloid-player/celluloid Feel free to assign it to me. (In reply to leigh scott from comment #10) > (In reply to Vasiliy Glazov from comment #3) > > Approved. > > Thanks for the review can you set the + flag so I can process the request > please? > > Fedora-review flag not approved Can you set it again as I have clubbed the + with my last response :-( Seems imported. |