Bug 5468

Summary:	Review Request: gstreamer-ffmpeg - GStreamer FFmpeg-based plug-ins
Product:	Package Reviews	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Review Request	Assignee:	leigh scott <leigh123linux>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	leigh123linux, rpmfusion-package-review
Priority:	P1	Flags:	leigh123linux: fedora-review+
Version:	Current
Hardware:	x86_64
OS:	GNU/Linux
namespace:	free
Bug Depends on:
Bug Blocks:	5466

Description Dominik 'Rathann' Mierzejewski 2019-11-21 10:39:19 CET

Spec URL: https://www.greysector.net/~rathann/review/gstreamer-ffmpeg/gstreamer-ffmpeg.spec
SRPM URL: https://www.greysector.net/~rathann/review/gstreamer-ffmpeg/gstreamer-ffmpeg-0.10.13-23.fc32.src.rpm

Description: GStreamer is a streaming media framework, based on graphs of filters which
operate on media data. Applications using this library can do anything
from real-time sound processing to playing videos, and just about anything
else media-related.  Its plugin-based architecture means that new data
types or processing capabilities can be added simply by installing new
plugins.

This package provides FFmpeg-based GStreamer plug-ins.

FAS: rathann

This is an unretirement review request.

Comment 1 leigh scott 2019-11-21 10:50:48 CET

Remove

Group:          Applications/Multimedia


change


make %{?_smp_mflags} V=1


to


%{make_build} V=1


change


make install DESTDIR=$RPM_BUILD_ROOT V=1


to


%{make_install} V=1


change


%files
%doc AUTHORS COPYING ChangeLog NEWS README TODO


to


%files
%doc AUTHORS ChangeLog NEWS README TODO
%license COPYING

The spec file also uses old style macros

$RPM_OPT_FLAGS

and

$RPM_BUILD_ROOT

Comment 2 leigh scott 2019-11-21 10:52:18 CET

Another issue is it must also build on rawhide, gstreamer is missing there.

Comment 3 Dominik 'Rathann' Mierzejewski 2019-11-21 14:00:30 CET

Thanks for the review.

gstreamer is in some kind of limbo in rawhide. I opened a releng ticket to fix it: https://pagure.io/releng/issue/9044 .

Comment 4 leigh scott 2019-11-21 16:46:53 CET

Approved

Comment 5 leigh scott 2019-12-03 11:40:48 CET

When you request branches and build you will also need to rebuild rpmfusion-free-obsolete-packages

https://pkgs.rpmfusion.org/cgit/free/rpmfusion-free-obsolete-packages.git/commit/?id=9fc52ec55a5379c7dd0aac2a3c8de6b86d8f1651

Comment 6 Dominik 'Rathann' Mierzejewski 2019-12-05 10:16:18 CET

(In reply to leigh scott from comment #5)
> When you request branches

Um. How do I do that these days?

> and build you will also need to rebuild
> rpmfusion-free-obsolete-packages
> 
> https://pkgs.rpmfusion.org/cgit/free/rpmfusion-free-obsolete-packages.git/
> commit/?id=9fc52ec55a5379c7dd0aac2a3c8de6b86d8f1651

Thanks for the tip, but it's not immediately necessary, thanks to the versioned Obsoletes/Provides. I'll do that after the builds are out.

Comment 7 Nicolas Chauvet 2019-12-05 10:24:13 CET

(In reply to Dominik 'Rathann' Mierzejewski from comment #6)
> (In reply to leigh scott from comment #5)
> > When you request branches
> 
> Um. How do I do that these days?
It's probably on the wiki...

> > and build you will also need to rebuild
> > rpmfusion-free-obsolete-packages
> > 
> > https://pkgs.rpmfusion.org/cgit/free/rpmfusion-free-obsolete-packages.git/
> > commit/?id=9fc52ec55a5379c7dd0aac2a3c8de6b86d8f1651
> 
> Thanks for the tip, but it's not immediately necessary, thanks to the
> versioned Obsoletes/Provides. I'll do that after the builds are out.
Please, don't as the obsoletes/provide is versioned, we could eventually remove it on master only, but we usually don't updates in branches for this packages.

Comment 8 leigh scott 2019-12-05 10:26:50 CET

(In reply to Dominik 'Rathann' Mierzejewski from comment #6)
> (In reply to leigh scott from comment #5)
> > When you request branches
> 
> Um. How do I do that these days?
> 

Try requesting unretirement on pkgdb

https://admin.rpmfusion.org/pkgdb/package/free/gstreamer-ffmpeg/

Comment 9 Dominik 'Rathann' Mierzejewski 2019-12-05 10:32:34 CET

(In reply to leigh scott from comment #8)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #6)
> > Um. How do I do that these days?
> 
> Try requesting unretirement on pkgdb
> 
> https://admin.rpmfusion.org/pkgdb/package/free/gstreamer-ffmpeg/

Done! I also requested F31 branch.

Thanks, I forgot RPM Fusion still had pkgdb. I actually don't remember when the last time I submitted a review request here was. ;)

Comment 10 leigh scott 2019-12-05 11:26:52 CET

(In reply to Dominik 'Rathann' Mierzejewski from comment #9)
> (In reply to leigh scott from comment #8)
> > (In reply to Dominik 'Rathann' Mierzejewski from comment #6)
> > > Um. How do I do that these days?
> > 
> > Try requesting unretirement on pkgdb
> > 
> > https://admin.rpmfusion.org/pkgdb/package/free/gstreamer-ffmpeg/
> 
> Done! I also requested F31 branch.
> 
> Thanks, I forgot RPM Fusion still had pkgdb. I actually don't remember when
> the last time I submitted a review request here was. ;)

I think I have managed to process the requests ok, the cli tool didn't manage to process the unretirement request.

https://admin.rpmfusion.org/pkgdb/package/free/gstreamer-ffmpeg/

https://pkgs.rpmfusion.org/cgit/free/gstreamer-ffmpeg.git/

Comment 11 Dominik 'Rathann' Mierzejewski 2019-12-05 14:51:29 CET

Thanks. I'll test and submit new builds soon.

Comment 12 Dominik 'Rathann' Mierzejewski 2019-12-05 15:03:57 CET

Looks like gstreamer-plugins-base was not unretired completely: https://pagure.io/releng/issue/9084 .

Comment 13 Dominik 'Rathann' Mierzejewski 2019-12-06 10:20:26 CET

Built for f31: http://koji.rpmfusion.org/koji/buildinfo?buildID=13229 . Waiting for releng to unblock gstreamer-plugins-base in rawhide to build there.

Comment 14 Dominik 'Rathann' Mierzejewski 2019-12-16 00:20:34 CET

Looks like the buildroot got synchronized and Leigh was able to build it for F32, too: http://koji.rpmfusion.org/koji/buildinfo?buildID=13242 . Closing.