Bug 5565

Summary: akmod fails to compile broadcom-wl on kernels >= 5.6.0
Product: Fedora Reporter: bugs.glenn
Component: broadcom-wlAssignee: NVieville <nicolas.vieville>
Status: RESOLVED FIXED    
Severity: major CC: leigh123linux
Priority: P1    
Version: f32   
Hardware: x86_64   
OS: GNU/Linux   
namespace:
Attachments: fixes compile issues on 5.6.x
Failed and successful akmods logs
akmod-wl-6.30.223.271-32.fc32 fix logs

Description bugs.glenn 2020-03-18 03:21:49 CET 
Created attachment 2161 [details]
fixes compile issues on 5.6.x

pkg version: wl-kmod-6.30.223.271-31.fc32

There has been a few changes to functions that broadcom-wl uses that causes it to fail to compile against the newer kernel.

- ioremap_nocache was removed since ioremap does this functionality by default: https://github.com/torvalds/linux/commit/4bdc0d676a643140bdf17dbf7eafedee3d496a3c

- proc_create_data param changed: https://github.com/torvalds/linux/commit/d56c0d45f0e27f814e87a1676b6bdccccbc252e9

Attached a patch that gets it building again on 5.6.x. There's no equivalent to the existing owner field in the proc_ops struct, I didn't dig into it but possibly the field is no longer relevant. The patch is missing the appropriate guard for compiling against older kernels with the older struct also.

Been using my patched wl module for a half hour. No issues so far, but I'll flag it if I see something.
Comment 1 NVieville 2020-03-19 09:04:40 CET 
Hello,

Thanks for reporting this issue and for providing a patch to solve it.

As you suggested, I will modify and apply the patch as soon as possible. I'll will post here a message when this will be done.

As I don't use F32 or Rawhide on my laptop (professional use), I wonder if you could tell me if you noticed some other errors or warning messages from gcc10 while the building of the wl module (thinking about such a thing described here: https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md#legacy-fcommon). 

If you can, I would really appreciate if you could provide the last package build logs (failed and successful) usually located in /var/cache/akmods/wl directory.

Thanks in advance.

Feel free to make any comment about this subject.

Cordially,


-- 
NVieville
Comment 2 bugs.glenn 2020-03-19 23:18:39 CET 
Created attachment 2164 [details]
Failed and successful akmods logs

Sure thing, akmods logs attached. From memory, I don't recall seeing any warnings in console.
Comment 3 NVieville 2020-03-20 11:31:15 CET 
(In reply to bugs.glenn from comment #2)
> Failed and successful akmods logs

Thank you very much.

> Sure thing, akmods logs attached. From memory, I don't recall seeing any
> warnings in console.

I wonder if you could please give a try to the newly build package fixing this issue available here:

http://koji.rpmfusion.org/koji/buildinfo?buildID=14643

In a root console:

dnf install http://koji.rpmfusion.org/kojifiles/packages/wl-kmod/6.30.223.271/32.fc32/x86_64/akmod-wl-6.30.223.271-32.fc32.x86_64.rpm

Any comments are welcome.

Cordially,


-- 
NVieville
Comment 4 bugs.glenn 2020-03-21 04:41:12 CET 
Created attachment 2165 [details]
akmod-wl-6.30.223.271-32.fc32 fix logs

> I wonder if you could please give a try to the newly build package fixing
> this issue available here:
> 
> http://koji.rpmfusion.org/koji/buildinfo?buildID=14643
> 
> In a root console:
> 
> dnf install
> http://koji.rpmfusion.org/kojifiles/packages/wl-kmod/6.30.223.271/32.fc32/
> x86_64/akmod-wl-6.30.223.271-32.fc32.x86_64.rpm

Success, thanks! Logs attached.
Comment 5 NVieville 2020-03-21 10:36:07 CET 
Hello,

Thank you very much for your feedback.

I'll close this bug report in the next days.

Feel free to re-open it, if needed.

Cordially,


-- 
NVieville