Bug 5801

Summary:	Review request: loudgain - ReplayGain 2.0 audio loudness normalizer
Product:	Package Reviews	Reporter:	Peter Oliver <rpmfusion.org>
Component:	Review Request	Assignee:	Dominik 'Rathann' Mierzejewski <dominik>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	dominik, rpmfusion-package-review
Priority:	P1	Flags:	dominik: fedora-review+
Version:	Current
Hardware:	x86_64
OS:	GNU/Linux
namespace:	free
Bug Depends on:
Bug Blocks:	4

Description Peter Oliver 2020-10-19 14:30:19 CEST

Spec URL: https://www.mavit.org.uk/loudgain/loudgain.spec
SRPM URL: https://www.mavit.org.uk/loudgain/loudgain-0.6.8-1.fc32.src.rpm

loudgain is a versatile ReplayGain 2.0 loudness normalizer, based on the
EBU R128/ITU BS.1770 standard (-18 LUFS) and supports
FLAC/Ogg/MP2/MP3/MP4/M4A/ALAC/Opus/ASF/WMA/WAV/WavPack/AIFF/APE audio
files. It uses the well-known mp3gain commandline syntax but will never
modify the actual audio data.

This package is not eligible to be included in Fedora because it depends on ffmpeg.

$ rpmlint loudgain-0.6.8-1.fc32.src.rpm 
loudgain.src: W: spelling-error Summary(en_US) normalizer -> normalize, normalizes, normalized
loudgain.src: W: spelling-error %description -l en_US normalizer -> normalize, normalizes, normalized
loudgain.src: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment
loudgain.src: W: patch-not-applied Patch0: hardened-build.patch
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

The spellings seem fine to me.
The patch is applied by %forgeautosetup, which appears not to be recognised by rpmlint.

$ rpmlint loudgain-0.6.8-1.fc32.x86_64.rpm
loudgain.x86_64: W: spelling-error Summary(en_US) normalizer -> normalize, normalizes, normalized
loudgain.x86_64: W: spelling-error %description -l en_US normalizer -> normalize, normalizes, normalized
loudgain.x86_64: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment
loudgain.x86_64: W: no-manual-page-for-binary rgbpm
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Upstream do not provide a man page for the rgbpm script.

Comment 1 Dominik 'Rathann' Mierzejewski 2021-01-11 13:38:25 CET

SPEC is clean.
License field looks fine.
Builds in rawhide and F33.
Works fine in F33.

Package APPROVED.

Comment 2 Peter Oliver 2021-01-13 14:48:48 CET

Thanks for the review!

I have requested a repo via pkgdb.

Comment 3 Dominik 'Rathann' Mierzejewski 2021-01-13 14:52:18 CET

I think the review bug should remain assigned to the reviewer. Why did you change it?

https://fedoraproject.org/wiki/Package_Review_Process
...
Check that your review bug is valid: it must have the fedora-review set to +, and it must be assigned to your reviewer, otherwise your repository request will be closed as invalid.

Comment 4 Peter Oliver 2021-01-14 13:46:13 CET

Build failure on rawhide looks to be caused by https://bugzilla.redhat.com/show_bug.cgi?id=1915928, recently fixed.  Will try again once mirrors sync.

Build failure on f33 is caused by a failure to set up a buildroot.  This also looks like it might go away after a mirror sync.

Build on f32 was okay.