Bug 5881

Summary:	vdr-skindesigner is not working out-of-the-box because of missing requirement and dtd directory
Product:	Fedora	Reporter:	Peter Bieringer <pb>
Component:	vdr-skindesigner	Assignee:	mgansser <mgansser>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	P1
Version:	f33
Hardware:	x86_64
OS:	GNU/Linux
namespace:

Description Peter Bieringer 2020-12-28 17:29:01 CET

vdr-skindesigner-1.2.8.6-1.fc33.x86_64

has 2 issues:


issue 1: required dtd files are packaged in "vdr-skindesigner-data", but this is not a dependency requirement for "vdr-skindesigner"

recommendation: move dtd and script files into base package


issue 2: looks like dtd is expected in /etc/vdr/plugins/skindesigner while contained (currently) by "vdr-skindesigner-data" but located in "/usr/share/vdr/plugins/skindesigner/dtd"

solution: create a softlink
ln -s /usr/share/vdr/plugins/skindesigner/dtd /etc/vdr/plugins/skindesigner/

recommendation: create the softlink either by rpm spec or postinstall

Dez 28 17:04:12 *** vdr[10418]: [10418] skindesigner: Error in XML: failed to load external entity "/etc/vdr/plugins/skindesigner/dtd/globals.dtd"
Dez 28 17:04:12 *** vdr[10418]: [10418] skindesigner: Error in XML: Validation failed: no DTD found !
Dez 28 17:04:12 *** vdr[10418]: [10418] skindesigner: Failed to validate XML File
Dez 28 17:04:12 *** vdr[10418]: [10418] skindesigner: error parsing globals, aborting
Dez 28 17:04:12 *** vdr[10418]: [10418] skindesigner: error during loading of templates - using LCARS as backup


beside the 2 issues, it's working fine so far - thank you!

Comment 1 mgansser@online.de 2020-12-29 09:25:32 CET

Servus,

can you please have a look to the rpm spec file, if this is ok ?
https://martinkg.fedorapeople.org/Packages/vdr-skindesigner/vdr-skindesigner.spec

Comment 2 Peter Bieringer 2020-12-29 10:20:24 CET

imho, vdr-skindesigner-data should only contain the two "builtin" skins

vdr-skindesigner-data:
/usr/share/vdr/plugins/skindesigner
/usr/share/vdr/plugins/skindesigner/installerskins
-> base package (to be able to install skin repos without the data package)

vdr-skindesigner:
/var/lib/vdr/data/themes/estuary4vdr-applegreen.theme
/var/lib/vdr/data/themes/estuary4vdr-bright.theme
/var/lib/vdr/data/themes/estuary4vdr-darkred.theme
/var/lib/vdr/data/themes/estuary4vdr-default.theme
/var/lib/vdr/data/themes/estuary4vdr-orange.theme
/var/lib/vdr/data/themes/metrixhd-birdie.theme
/var/lib/vdr/data/themes/metrixhd-default.theme
/var/lib/vdr/data/themes/metrixhd-green.theme
/var/lib/vdr/data/themes/metrixhd-orange.theme
/var/lib/vdr/data/themes/metrixhd-raspberry.theme
-> data package

Comment 3 mgansser@online.de 2020-12-29 10:54:50 CET

I created a new rpm spec file, I'm not sure if it fits now.
https://martinkg.fedorapeople.org/Packages/vdr-skindesigner/vdr-skindesigner.spec

Comment 4 Peter Bieringer 2020-12-29 11:31:17 CET

looks well now, skindesigner can be installed without "data" subpackage, "dtd" softlink is created, thank you!

Comment 5 mgansser@online.de 2020-12-29 13:31:49 CET

package successfully build for rawhide, f33 and f32.