Bug 5971

Summary:	Build ffmpeg with svt-vp9 and svt-hevc support
Product:	Fedora	Reporter:	Vasiliy Glazov <vascom2>
Component:	ffmpeg	Assignee:	Dominik 'Rathann' Mierzejewski <dominik>
Status:	RESOLVED WONTFIX
Severity:	enhancement	CC:	belegdol, kwizart, leigh123linux
Priority:	P1
Version:	unspecified
Hardware:	x86_64
OS:	GNU/Linux
namespace:

Description Vasiliy Glazov 2021-04-13 07:22:14 CEST

I want to suggest build ffmpeg with svt-vp9 and svt-hevc support.
svt-vp9 available in main Fedora repo. svt-hevc in rpmfusion repo.

It needs this changes to ffmpeg spec:
+Patch1:         master-0001-Add-ability-for-ffmpeg-to-run-svt-vp9.patch
+Patch2:         0001-lavc-svt_hevc-add-libsvt-hevc-encoder-wrapper.patch
+BuildRequires:  svt-vp9-devel
+BuildRequires:  svt-hevc-devel

+    --enable-libsvtvp9 \\\
+    --enable-libsvthevc \\\

Patches available here
https://github.com/OpenVisualCloud/SVT-VP9/tree/master/ffmpeg_plugin
https://github.com/OpenVisualCloud/SVT-HEVC/tree/master/ffmpeg_plugin

I don't see how to make Pull Request. So I want to ask what should I do: give patch to ffmpeg.spec here or directly add this changes to git repo and make build?

Comment 1 Nicolas Chauvet 2021-04-13 08:50:46 CEST

What's the benefit for this change ?
What is the upstream status of theses patches ?

Comment 2 leigh scott 2021-04-13 09:18:41 CEST

I wont use non-upstream patches!

Comment 3 Vasiliy Glazov 2021-04-13 09:28:50 CEST

Benefit: use fast hardware Intel Processors coding to this formats.

Upstream status unknown.

https://github.com/OpenVisualCloud/SVT-VP9/issues/139
Q: Why is the ffmpeg patch not already in ffmpeg master?
A: It requires a lot of effort and cleanup to upstream the patch and we do not have the resources and time to do so at this moment.

For the svt-hevc I think the same status.

Comment 4 Vasiliy Glazov 2021-04-13 09:28:59 CEST

If non-upstream patches are not welcome then this issue can be closed.

Comment 5 leigh scott 2021-04-13 09:47:46 CEST

I see they can't be bothered to upstream.

https://github.com/OpenVisualCloud/SVT-VP9/issues/139

Comment 6 leigh scott 2021-04-13 13:34:32 CEST

(In reply to Vasiliy Glazov from comment #3)
> Benefit: use fast hardware Intel Processors coding to this formats.
> 
> Upstream status unknown.
> 
> https://github.com/OpenVisualCloud/SVT-VP9/issues/139
> Q: Why is the ffmpeg patch not already in ffmpeg master?
> A: It requires a lot of effort and cleanup to upstream the patch and we do
> not have the resources and time to do so at this moment.
> 
> For the svt-hevc I think the same status.

It seems they were to lazy to attach the patches to the enhancement request.

https://trac.ffmpeg.org/ticket/7914