Bug 6187

Summary: Review request: dcaenc - Dcaenc DTS 5.1 encoder
Product: Package Reviews Reporter: Коренберг Марк <marik>
Component: Review RequestAssignee: Vasiliy Glazov <vascom2>
Status: RESOLVED MOVED    
Severity: enhancement CC: rpmfusion-package-review, vascom2
Priority: P1    
Version: Current   
Hardware: x86_64   
OS: GNU/Linux   
namespace: free

Description Коренберг Марк 2022-01-03 20:10:07 CET
https://github.com/socketpair/dcaenc-rpm


This is an Alsa plugin for encoding sound to DTS 5.1 format. Highly useful for broken HDMI or S/PDIF receivers.

I want the package to be included in Fedora Fusion collection since it really helps many guys to get 5.1 sound in MUCH stable way comparing to a52 Alsa plugin.

All Rpmlint warnings were fixed.

It's my first RPM Fusion package.

I'm seeking a sponsor.
Comment 1 Коренберг Марк 2022-01-03 20:14:57 CET
Should I better make changes to https://github.com/rpmfusion/alsa-plugins-freeworld/blob/master/alsa-plugins-freeworld.spec ?
Comment 2 Vasiliy Glazov 2022-01-03 20:38:37 CET
Please post direct URLs to spec and srpm.
Comment 3 Vasiliy Glazov 2022-01-03 20:41:25 CET
This code or algorithm has patent restrictions? Why not in free section or main Fedora repo?
Comment 4 Коренберг Марк 2022-01-03 20:56:06 CET
https://github.com/socketpair/dcaenc-rpm/releases/download/test_tag/dcaenc-3-1.1641240505.2.ef0e39d.fc34.src.rpm

https://github.com/socketpair/dcaenc-rpm/releases/download/test_tag/dcaenc.spec

Yes, this algorithm HAS U.S. patent. Specifications on DTS are free, but implementation is patented.
Comment 5 Nicolas Chauvet 2022-01-03 20:57:01 CET
Thanks for your interest in joining RPM Fusion.

Can you clarify why you think this package is relevant only for rpmfusion ? (or even nonfree ?)
I wonder if DTS still have active patent ?
(so this might be allowed in fedora).


Maybe the plugin part should be better handled in the alsa-plugins upstream sources at https://www.alsa-project.org/ ? (so it will end in the fedora alsa-plugins package instead...)
Comment 6 Nicolas Chauvet 2022-01-03 21:01:31 CET
From a quick search, some patents have expired not sure if all of them have...
https://patents.google.com/patent/US6760448
https://patents.google.com/patent/US5956674A
Comment 8 Коренберг Марк 2022-01-03 22:05:08 CET
Actually, there are two DTS specs, used to write the encoder. One of them does not contain any patent references.

Also, the decoder (libdca) is in rpmfusion-free.

I don't know. Possibly libdca also should be moved to main Fedora repository because of some patents expiration.

P.S. There is the latest DTS spec, containing some patent references.

https://www.etsi.org/deliver/etsi_ts/102100_102199/102114/01.01.01_60/ts_102114v010101p.pdf (very old - actually it was only used for writing the code)

https://www.etsi.org/deliver/etsi_ts/102100_102199/102114/01.03.01_60/ts_102114v010301p.pdf (old)

https://www.etsi.org/deliver/etsi_ts/102100_102199/102114/01.05.01_60/ts_102114v010501p.pdf (latest)

The last references this: https://www.etsi.org/deliver/etsi_sr/000300_000399/000314/02.26.02_60/sr_000314v022602p.pdf


PLEASE help me decide where to put the package. I would like to put it in main Fedora repos, and also strike libdca authors to do the same.
Comment 9 Nicolas Chauvet 2022-01-04 09:04:28 CET
> I don't know. Possibly libdca also should be moved to main Fedora repository because of some patents expiration.

It's well possible. We can migrate libdca to fedora at one point.

> PLEASE help me decide where to put the package.
Best would be to submit a fedora review first, then head the legal review.
We could still re-open the review here if the legal review is negative.
Comment 10 Nicolas Chauvet 2023-03-13 11:03:49 CET
libdca was moved into fedora.

Please open the review in fedora 
(you can add the link here for theses interested).