Bug 6283

Summary: Review request: pgplot - Graphic library for making simple scientific graphs
Product: Fedora Reporter: niktr
Component: pgplotAssignee: Sergio Pascual <sergio.pasra>
Status: NEW ---    
Severity: enhancement CC: niktr, rpmfusion-package-review
Priority: P1    
Version: unspecified   
Hardware: x86_64   
OS: GNU/Linux   
namespace: nonfree

Description niktr 2022-04-20 12:32:51 CEST
This is enhancement of pgplot package adding motif driver to it.
This is my first package.
https://cloud.mail.ru/public/eE3Q/2QU2GETvv
https://cloud.mail.ru/public/WtxL/Dn5A3WYMY
The PGPLOT Graphics Subroutine Library is a Fortran- or C-callable,
device-independent graphics package for making simple scientific graphs.
It is intended for making graphical images of publication quality with
minimum effort on the part of the user. For most applications,
the program can be device-independent, and the output can be directed to
the appropriate device at run time.
[]$ rpmlint ../RPMS/x86_64/motif-pgplot-5.2.2-52.fc35.x86_64.rpm 
======================================================== rpmlint session starts ========================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

motif-pgplot.x86_64: W: invalid-license freely available for non-commercial use
========================= 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 3.0 s =========================
[]$ rpmlint ../RPMS/x86_64/motif-pgplot-devel-5.2.2-52.fc35.x86_64.rpm 
======================================================== rpmlint session starts ========================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

motif-pgplot-devel.x86_64: W: invalid-license freely available for non-commercial use
========================= 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s =========================

[]$ rpmlint ../SRPMS/pgplot-5.2.2-52.fc35.src.rpm 
======================================================== rpmlint session starts ========================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

pgplot.spec: W: patch-not-applied Patch3: pgplot5.2-pngdriver.patch
pgplot.spec:116: W: macro-in-comment %patch3
pgplot.src: W: invalid-license freely available for non-commercial use
========================= 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.3 s =========================
Comment 1 Nicolas Chauvet 2022-04-20 13:29:36 CEST
Can you submit a PR against github.com/rpmfusion/pgplot so the maintainer can review the changes ?


This looks fine at first step, but up for the maintainer to review.
Comment 2 niktr 2022-04-22 07:57:49 CEST
Will do.
Thanks.