Bug 6403

Summary:	minidlna 1.3.2 is available and I'd like add multiple_captions_support.patch
Product:	Fedora	Reporter:	Sérgio Basto <sergio>
Component:	minidlna	Assignee:	Andrea Musuruane <musuruan>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	leigh123linux
Priority:	P1
Version:	f38
Hardware:	x86_64
OS:	GNU/Linux
namespace:
Attachments:	0001-Update-minidlna-to-1.3.2.patch

Description Sérgio Basto 2022-08-31 23:34:04 CEST

over official minidlna release ve been testing  https://sourceforge.net/p/minidlna/git/merge-requests/37/ for me the most important patch is about support scanning multiple captions for a media, which let me videos with country suffix.srt .

Do you let me apply such patches in minidlna rpmfusion package ? 

Best regards,

Comment 1 leigh scott 2022-09-01 12:08:20 CEST

-1 to mass patching, your upstream Pr will probably be rejected because of this.
Maybe submit the changes separately.

Comment 2 leigh scott 2022-09-01 12:08:45 CEST

-1 to mass patching, your upstream Pr will probably be rejected because of this.
Maybe submit the changes separately.

Comment 3 Andrea Musuruane 2022-09-01 12:23:44 CEST

I will update minidlna but I won't include patches that implement new features because I don't want to deviate from upstream.

Comment 4 Sérgio Basto 2022-09-01 12:32:45 CEST

upstream have accept some patches but with modifications , for example I just verified minidlna-1.3.0-fd-leak.patch is already in source . 

first 9 commits are already in RPMFusion , the other 9 the most important is but it will change internal sqllite structure and we need rebuild all minidlna database again

Comment 5 Sérgio Basto 2022-09-01 12:33:50 CEST

the most important is https://sourceforge.net/u/sergiomb/minidlna/ci/b740ff539bb18f2b585bdc78c699e3a6b79aa704/

Comment 6 Andrea Musuruane 2022-09-01 12:37:53 CEST

(In reply to Sérgio Basto from comment #5)
> the most important is
> https://sourceforge.net/u/sergiomb/minidlna/ci/
> b740ff539bb18f2b585bdc78c699e3a6b79aa704/

I won't include this patch as long as it is not accepted upstream.

I repeat. I don't want to deviate from upstream. And you should do the same too:
https://docs.fedoraproject.org/en-US/package-maintainers/Staying_Close_to_Upstream_Projects/

Comment 7 Sérgio Basto 2022-09-01 13:20:16 CEST

multiple_captions is very important to me , since minidlna won't read foo.pt.srt   and only read foo.srt for foo.mp4 movie

Comment 8 Sérgio Basto 2022-09-03 05:07:30 CEST

Created attachment 2420 [details]
0001-Update-minidlna-to-1.3.2.patch

my proposed patch to update minidlna im rpmfusion

Comment 9 Andrea Musuruane 2022-09-03 08:14:43 CEST

(In reply to Sérgio Basto from comment #8)
> Created attachment 2420 [details]
> 0001-Update-minidlna-to-1.3.2.patch
> 
> my proposed patch to update minidlna im rpmfusion

I'm already working on an update.

Comment 10 Andrea Musuruane 2022-09-03 17:26:32 CEST

Built for F36+,