Bug 6976

By the way, I forgot to mention, it would be interesting to add also these lines:

    <custom>
      <value key="GnomeSoftware::requires-akmods-key">True</value>
    </custom>

into the `component`-s for `xorg-x11-drv-nvidia-470xx` and `xorg-x11-drv-nvidia`, thus they are marked with it at the source (and other packages can adapt it), instead of having a custom appstream data separated in the gnome-software itself.

The idea behind this custom data is to allow anyone being marked as "requires-akmods-key", which triggers special code in the gnome-software (when it has this akmods code enabled).

If such addition is acceptable, you can do it once the merge request is fully approved, in case the key would be renamed or anything like that. I can file a new bug when it's approved, if you agree.

Thanks for getting in touch and helping to land that feature.

As I'm concerned, I'm generally positive to the feature. That said I share with Leigh mainly two concerns (at least):
- We were requested for the f40 timeframe to remove that appstream data for the nvidia-driver repository. It would be nice not to go back and forth once again with that.

- Some security aspects are involved and while the akmods framework permit to deal with end-users own secureboot key there are security implications to protect such key ().

In order to achieve theses goals, I would like this methodology:
- Discussion to be made (preferably on the fedora mailing list, unless some implementation needs to be asked here), and leave some reasonable time.
- Then we make a decision (and hold with that).


As akmods maintainer, removing the secureboot key can eventually be made at the akmod level.


About the -cuda sub-package, It can probably be advertised on the appdata. But when the nvidia-cuda repository is installed, it will automatically brings the cuda sub-package on-purpose (as discussed with nvidia dev some time ago).
So this should really be an implementation detail.
Now we could verify that nvidia driver appdata contains CUDA and related keywords to clarify this, if needed.


Can the akmods-key custom value be made even when not supported ?( older Fedora/ Older RHEL) ? If not we need to conditionality this key instead of having the same appdata for all branches.

> - We were requested for the f40 timeframe to remove that appstream data for the nvidia-driver repository. It would be nice not to go back and forth once again with that.

I completely agree with this. That was a very unfortunate decision. I cannot promise anything myself, I'm not the decision maker here, I'm even not part of the Fedora Workstation group, thus my word doesn't count much, though I hope (and believe) once the gnome-software work will land the appstream data will be needed, thus no new removal request will follow. At least from my point of view.

> About the -cuda sub-package, It can probably be advertised on the appdata. But when
> the nvidia-cuda repository is installed, it will automatically brings the cuda
> sub-package on-purpose (as discussed with nvidia dev some time ago).

Aha, I see, I did not know that. I tried with the default repo from Fedora and even it know the CUDA subpackage, it's not brought in together with the NVIDIA drivers package, thus I opened this concern. There's brought in only xorg-x11-drv-nvidia-cuda-libs, not xorg-x11-drv-nvidia-cuda (while this later package description reads `This package provides the CUDA driver.`).

> Can the akmods-key custom value be made even when not supported ?

Yes, it can be included everywhere and it'll not have any impact (apart of ignoring the elements) for anything not knowing about it.

(In reply to Nicolas Chauvet from comment #2)
> - Discussion to be made (preferably on the fedora mailing list, unless some
> implementation needs to be asked here), and leave some reasonable time.
> - Then we make a decision (and hold with that).

Would it suffice to be part of the F41 change proposal discussion here
https://discussion.fedoraproject.org/t/f41-change-proposal-nvidia-driver-installation-with-secure-boot-support-self-contained/120330/1
and here:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/KT65NV5T26TUHOBIPZ3Z6NRXWRY6TDRL/

or you'd like to see a new pagure bug against the fedora-workstation, similar to the 155 mentioned in the description?

(In reply to Milan Crha from comment #1)
> By the way, I forgot to mention, it would be interesting to add also these
> lines:
> 
>     <custom>
>       <value key="GnomeSoftware::requires-akmods-key">True</value>
>     </custom>
> 
> into the `component`-s for `xorg-x11-drv-nvidia-470xx` and
> `xorg-x11-drv-nvidia`, thus they are marked with it at the source (and other
> packages can adapt it), instead of having a custom appstream data separated
> in the gnome-software itself.
> 
> The idea behind this custom data is to allow anyone being marked as
> "requires-akmods-key", which triggers special code in the gnome-software
> (when it has this akmods code enabled).
> 
> If such addition is acceptable, you can do it once the merge request is
> fully approved, in case the key would be renamed or anything like that. I
> can file a new bug when it's approved, if you agree.

Pull requests for this would be gratefully received.

 https://github.com/rpmfusion?q=nvidia&type=all&language=&sort=

The appdata files don't get much attention.

> Pull requests for this would be gratefully received.

Okay, thanks. I'll open one once I know the name will stand as it currently is in the gnome-software merge request.

(In reply to Milan Crha from comment #6)
> > Pull requests for this would be gratefully received.
> 
> Okay, thanks. I'll open one once I know the name will stand as it currently
> is in the gnome-software merge request.

I've got the confirmation, thus I opened:

https://github.com/rpmfusion/xorg-x11-drv-nvidia/pull/5
https://github.com/rpmfusion/xorg-x11-drv-nvidia-470xx/pull/2