Bug 980

Updates:
http://cwickert.fedorapeople.org/review/pragha.spec
http://cwickert.fedorapeople.org/review/pragha-0.7.3-1.fc14.src.rpm

Nice addition, we have so few nice and simple media players in Fedora. I miss xmms. Couple of things:

> ls -lFh /usr/share/doc/pragha-0.7.3/
total 8.0K
-rwxr-xr-x 1 root root 2.8K 2009-10-21 00:38 ChangeLog*
-rwxr-xr-x 1 root root  798 2009-10-21 00:38 FAQ*
-rwxr-xr-x 1 root root    0 2009-10-21 00:38 README*


Can you remove the empty file and the executable flags to the other 2?

Second, by default the volume control doesn't appear to work with pulseaudio. I had to go into the preferences menu and select the software mixer. Is it possible to make this default ?

(In reply to comment #2)
> Nice addition, we have so few nice and simple media players in Fedora.

Are you serious of do I miss the irony? IMO there are quite a lot of simple media players, but many of them don't work properly.

> Can you remove the empty file and the executable flags to the other 2?

fixed.
 
> Second, by default the volume control doesn't appear to work with pulseaudio. I
> had to go into the preferences menu and select the software mixer. Is it
> possible to make this default ?

Sure, at least with a little patch.

SPEC: http://cwickert.fedorapeople.org/review/pragha.spec
SRPM: http://cwickert.fedorapeople.org/review/pragha-0.7.3-2.fc14.src.rpm

Thanks for spotting these!

Spec: http://cwickert.fedorapeople.org/review/pragha.spec
SRPM: http://cwickert.fedorapeople.org/review/pragha-0.7.4-1.fc14.src.rpm

Spec: http://cwickert.fedorapeople.org/review/pragha.spec
SRPM: http://cwickert.fedorapeople.org/review/pragha-0.7.7.1-1.fc14.src.rpm

formal review here:
+:ok, =:needs attention, -:needs fixing

MUST Items:
[+] MUST: rpmlint must be run on every package.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
list and more]
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
<<md5sum checksum>>73d5fdd6d2eb5434cff0087d29e6e630
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[=] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.


This packages is is approved.

Thanks for your review, sorry I missed it.

Package CVS request
======================
Package Name: pragha
Short Description: Lightweight GTK+ music manager
Owners: cwickert
Branches: F-12 F-13
InitialCC:
----------------------
License tag: [free]

Closing as this is accepted and CVS request has been completed.