SRPM: http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv-0.5.52-2.fc8.kwizart.src.rpm SPEC: http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv.spec Summary: A set of utilities to manage your TV viewing This package cannot be allowed in Fedora since it retrieve information from websites and thus could possibly violate EULA.
Here's some initial comments from a quick build : * rpmlint output not empty : xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_remove_some_overlapping 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_sort 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_text 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_potatoe 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_imdb 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_latex 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_validate_grabber 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_split 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_extractinfo_en 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_grep 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_find_grabbers 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_cat 0555 xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_validate_file 0555 xmltv.noarch: W: file-not-utf8 /usr/share/doc/xmltv-0.5.52/ChangeLog xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_eu_epgdata 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_be 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_no_gfeed 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_ch_search 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_fr 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_na_dd 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_pt 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_es 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_na_dtv 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_za 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_ee 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_es_laguiatv 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_uk_rt 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_it 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_dtv_la 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_br_net 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_re 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_combiner 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_es_miguiatv 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_ar 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_se_swedb 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_uk_bleb 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_jp 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_hr 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_huro 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_dk 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_na_icons 0555 xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_fi 0555 xmltv-gui.noarch: E: non-standard-executable-perm /usr/bin/tv_check 0555 * Duplicate requires in xmltv-grabbers : perl(WWW::Mechanize) perl(WWW::Mechanize) >= 1.02 perl(XML::Twig) perl(XML::Twig) >= 3.10 perl(XML::Twig) >= 3.28 * Does the main package needs to require -gui ? * Suggested additional BR: perl(Log::TraceMessages) (for debug purposes, from the README file) * add some of the doc/ subdir files to %%doc * make test needs to be fixed if at all possible. If not, only the failing tests should be disabled, not all of them. * missing desktop file for xmltv-gui
> Suggested additional BR: perl(Log::TraceMessages) (for debug purposes, from the README file) Anyone can take this (and dependencies ?) https://bugzilla.redhat.com/show_bug.cgi?id=458449
SRPM: http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv-0.5.53-1.fc8.kwizart.src.rpm SPEC: http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv.spec Summary: A set of utilities to manage your TV viewing - Update to 0.5.53 - Remove -gui requirement on main - filter perl-Tk dependency on perl-XMLTV - Re-enable make test * I don't think that creating a .desktop file is that necessary. I don't use that script often (never) anyway. But splitting it in a -gui subpackage will prevent to requires perl-Tk and Thus, huge gui dependencies. * Duplicate requires can probably be fixed by using the same value when "use" a perl package. That been said i cannot see any side effect and it will remains developpers care to request the same version. The others points should have been fixed. perl-Log-TraceMessages has been pushed to stable for F-8/F-9 today which is the last dependency that was missing. It is already available for Rawhide, right now.
* Duplicate Requires: in xmltv-grabbers : perl(WWW::Mechanize) perl(WWW::Mechanize) >= 1.02 perl(XML::Twig) perl(XML::Twig) >= 3.10 perl(XML::Twig) >= 3.28 Different grabbers require different versions of the same modules. I'd say the duplicates are harmless in this case. Filter them if you wish but I won't block on that. * missing desktop file for xmltv-gui The Fedora guidelines are pretty strict on this, so even if the use case is limited here, it'd be better to have one. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Either http://wiki.xmltv.org/favicon.ico or http://wiki.xmltv.org/logo.png can be used for the icon. * Islandic grabber is not built. Adding the following fixes it : BuildRequires: perl(XML::DOM) BuildRequires: perl(XML::LibXSLT)
(In reply to comment #4) > * missing desktop file for xmltv-gui > The Fedora guidelines are pretty strict on this, so even if the use case is > limited here, it'd be better to have one. > https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files > Either http://wiki.xmltv.org/favicon.ico or http://wiki.xmltv.org/logo.png can > be used for the icon. So..., I have investigated. The normal use would be to have: tv_check --scan --listings /someplace/XMLTV_grabbed.xml --shows ~/.xmltv/shows.xml (it would need to be --configured before). XMLTV_grabbed.xml is usually generated from tv_grab_yourlocale but there is no sure way where to expect this file.(It depend on where the related apps store the file, but system wide TV.xml file isn't common). Also shows.xml are user dependant, but might be different than the current users. (for example if user schlobinux want to check shows from mythtv or freevo within the schlobinux X session). I would add that .desktop files aren't designed to support parsing of two files until now, so it doesn't worth the case to use this as it will lead to hardcode the path, whereas it can change often and for different uses. > * Islandic grabber is not built. Adding the following fixes it : > BuildRequires: perl(XML::DOM) > BuildRequires: perl(XML::LibXSLT) Fixed and mock tested in Rawhide and F-8 (it works).
+ source files match upstream :9ee2d6c8bb192e214b2674042260cf36 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license + license is open source-compatible. License text is included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock. + package installs properly + rpmlint is silent. = final provides and requires are sane: Some duplicates requires with different versions specified. Harmless, perl(WWW::Mechanize) perl(WWW::Mechanize) >= 1.02 perl(XML::Twig) perl(XML::Twig) >= 3.10 perl(XML::Twig) >= 3.28 + %check is present and all tests pass + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. = No desktop file, but it's not really useful in this case. This package is APPROVED.
Package CVS request ====================== Package Name: xmltv Short Description: A set of utilities to manage your TV viewing Owners: kwizart Branch: devel F-9 F-8 EL-5 InitialCC: ---------------------- License tag: free
cvs done.
package imported.
Package Change Request ====================== Package Name: mythtv New Branches: EL-6 Updated EPEL Owners: hobbes1069@gmail.com ktdreyer@ktdreyer.com
Package Change Request ====================== Package Name: xmltv New Branches: EL-6 Updated EPEL Owners: hobbes1069@gmail.com ktdreyer@ktdreyer.com
I just wanted to ping this CVS request. Is there something that needs to be done before it can be completed? This is the last requirement for the EL-6 branch of MythTV.
(In reply to comment #12) > I just wanted to ping this CVS request. Is there something that needs to be Im' not sure to understand this request. So let's have some minimal formalism. As a CVS admin process holder, I need to have the agreement from the primary maintainer. That's the same with fedora and having an empty EL-6 branch doesn't mean a different process. As a primary maintainer of xmltv, I've requested to update to the latest version to verify the future maintainer capabilities. I use the very same process to allow co-maintainers on the package I'm responsible. This is how I got ACL for vlc, and later ffmpeg, despite at that time; the previous maintainer started to apply my patches without allowing me any ACL as a first step. So RPM Fusion might be a smaller crew, there is no reason to have less formalism than in Fedora. I really hopes to allow more maintainers to gain access, that's doesn't mean to bypass this very trivial process.
You didn't list any specific actions needed but I have done the following locally: - Updated to the latest released version. - Updated the noask patch. - Added a new binary and man page to %files. - Removed some optional spec stuff (BuildRoot:, %clean, %defattr...) - Fixed a bad end-of-line encoding - Reported a couple of bad FSF addresses upstream. https://sourceforge.net/tracker/?func=detail&aid=3547942&group_id=39046&atid=424135 Are there other actions you're looking for? Or specific packages this needs to be tested against?
I've run into an issue that EL6 does not provide perl(Text::Kakasi). In looking into this, I've found that none of the resulting rpms require it either so I'm not sure if it's really needed or not. I commented it out and the EL6 build did not appear to be affected.
(In reply to comment #14) > You didn't list any specific actions needed but I have done the following This was done to Ken Dreyer in another report for some reason.
(In reply to comment #16) > (In reply to comment #14) > > You didn't list any specific actions needed but I have done the following > This was done to Ken Dreyer in another report for some reason. https://bugzilla.rpmfusion.org/show_bug.cgi?id=2397 (In reply to comment #14) ... > Are there other actions you're looking for? Or specific packages this needs to > be tested against? That would be all.
(In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #14) > > > You didn't list any specific actions needed but I have done the following > > This was done to Ken Dreyer in another report for some reason. > https://bugzilla.rpmfusion.org/show_bug.cgi?id=2397 Yes, those comments look familiar, I just couldn't remember what BZ they were on. I guess one question I have is if perl-Text-Kakasi needs to be optional or not. It doesn't appear to affect building any of the grabbers (config output is the same with or without) and it doesn't show up in any of the package requirements. Why would we just not drop the BuildRequires: all together?
Ok, I figured out what's going on. the perl(Text:Kakasi) requirement is for tv_grab_jp (Japanese) but it's currently disabled in the source because the site that supplies the data is currently blocking xmltv. Because of that I have commented out the requirement in my version of the spec since it will not do anything anyway. If that's figured out in a later version it can be re-enabled. Is there anything else that needs to be completed before the cvs request can be processed?
Ok, added perl(DateTime::Format::ISO8601) and now tv_grab_na_dtv get's built and installed.
Nicolas, I'm ready to maintain xmltv unless you have some additional requirements. Do I need to update the CVS request?
Got a response from upstream on bad FSF addresses. They have been fixed.
There is still no spec update.
(In reply to comment #23) > There is still no spec update. https://dl.dropbox.com/u/34775202/xmltv.spec
(In reply to comment #24) > (In reply to comment #23) > > There is still no spec update. > > https://dl.dropbox.com/u/34775202/xmltv.spec I haven't received the related src.rpm so I cannot grab the missing patch. +# This is for tv_grab_jp which is currently disabled in source +#BuildRequires: perl(Text::Kakasi) Why this isn't properly conditionalized between fedora and el ? This perl module is available in fedora.
(In reply to comment #25) > (In reply to comment #24) > > (In reply to comment #23) > > > There is still no spec update. > > > > https://dl.dropbox.com/u/34775202/xmltv.spec > > I haven't received the related src.rpm so I cannot grab the missing patch. https://dl.dropbox.com/u/34775202/xmltv-0.5.63-1.fc16.src.rpm > +# This is for tv_grab_jp which is currently disabled in source > +#BuildRequires: perl(Text::Kakasi) > Why this isn't properly conditionalized between fedora and el ? > This perl module is available in fedora. Because the grabber is disabled upstream there's no reason to pull in the build requirement. If it's enabled at a later date then I would uncomment and conditionalize.
(In reply to comment #26) > (In reply to comment #25) > > (In reply to comment #24) > > > (In reply to comment #23) > > > > There is still no spec update. > > > > > > https://dl.dropbox.com/u/34775202/xmltv.spec > > > > I haven't received the related src.rpm so I cannot grab the missing patch. > > https://dl.dropbox.com/u/34775202/xmltv-0.5.63-1.fc16.src.rpm Ok, you have been added to the ACL for the current branches.