Bug 1445 (AvidemuxFAAC) - Can we re-enable FAAC in Avidemux now?
Summary: Can we re-enable FAAC in Avidemux now?
Status: RESOLVED WONTFIX
Alias: AvidemuxFAAC
Product: Fedora
Classification: Unclassified
Component: avidemux (show other bugs)
Version: 14
Hardware: All GNU/Linux
: P5 enhancement
Assignee: Richard
URL:
Depends on:
Blocks:
 
Reported: 2010-09-30 07:18 CEST by Henry Kroll
Modified: 2011-04-20 23:57 CEST (History)
2 users (show)

See Also:
namespace:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Kroll 2010-09-30 07:18:11 CEST 
FAAC was disabled temporarily last year. Seems to work fine when I re-enable it by uncomment of line 75 in avidemux.spec and rebuild. I'm not the most elite tester on the block but the resulting videos do seem to play fine in mplayer.

#BuildRequires:  faac-devel >= 1.24

* Sat Oct 24 2009 Stewart Adam <s.adam at diffingo.com> - 2.5.1-5.20091010svn
- Temporarily disable FAAC as per discussion on RF-dev ML
Comment 1 Stewart Adam 2010-09-30 08:18:12 CEST 
Avidemux would need to be moved to the nonfree repository for this to get done.

Please note that I am no longer maintaining avidemux [1], but I'm still the bug contact for now until a new owner takes over.

[1] http://www.mail-archive.com/rpmfusion-developers@lists.rpmfusion.org/msg08271.html
Comment 2 Stewart Adam 2010-10-26 21:04:59 CEST 
Kevin Kofler has provided me with a patch (untested) that enables the use of the experimental AAC encoder in ffmpeg. I've submitted a build for F-14.
Comment 3 Richard 2011-04-19 15:44:26 CEST 
As I'm the new maintainer for avidemux I'm trying to clean up the old bug reports.

Is this one more or less resolved? If we don't want to move avidemux to non-free then I don't see that there's anything to be done here.

Was the build for experimental AAC support in ffmpeg successful?
Comment 4 Richard 2011-04-20 23:57:03 CEST 
After doing some research I've settled on the following:

I don't think moving avidemux to nonfree just for faac is a good idea, although I'm not completely opposed to it. I'm not sure what all is involved. If you really want to pursue it reopen the bug.

Also, the patch for experimental aac encoding for ffmpeg does not work. It errors out immediately on init:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1659

I'm not sure if it's practical but I'm going to work on un-bundling libraries from avidemux as I have time. I'll look at ffmpeg first but it doesn't look like it will be easy.

Is looks like Stewart added a conditional to the spec to make rebuilding with faac easy.

If someone wants faac support they can download the source rpm, install it and do the following:

(as normal user, never build a package as root)
$ rpmbuild -bb rpmbuild/SPECS/avidemux.spec --with faac

and install the resulting rpms in ./rpmbuild/RPMS/<arch>/