Bug 8 (emuexec) - Review request: emuexec - Emulation simplifier
Summary: Review request: emuexec - Emulation simplifier
Status: RESOLVED WONTFIX
Alias: emuexec
Product: Package Reviews
Classification: Unclassified
Component: Review Request (show other bugs)
Version: Current
Hardware: All GNU/Linux
: P5 normal
Assignee: RPM Fusion Package Review
URL: http://www.kde-apps.org/content/show....
Depends on:
Blocks: kdeaddons-emulation
  Show dependency treegraph
 
Reported: 2007-09-28 17:30 CEST by Kelly Miller
Modified: 2008-12-15 13:57 CET (History)
2 users (show)

See Also:
namespace:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Miller 2007-09-28 17:30:41 CEST
SRPM: http://download.opensuse.org/repositories/home:/DarkPhoenixNixa/Fedora_7/src/emuexec-1.2-8.1.src.rpm
Specfile: http://crystalsanctuary.rpgsource.net/packages/specs/emuexec.spec

Emuexec is a program that helps to simplify the interfaces of different emulators, by providing one program with one set of options to start the different emulators.  It was designed to be used with kdeaddons-emulation, but can be used separately (though it's somewhat hard to configure without it).
Comment 1 Kelly Miller 2007-10-25 22:08:44 CEST
Um...
Comment 2 Andrea Musuruane 2007-11-08 14:46:53 CET
Just some comment as I quickly the spec file. This isn't a formal review.

- License tag does not follow Fedora Guidelines:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8

- Macro use is not consistent:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

You cannot use %{__cp} and rm in the same spec file. Use one of this two styles and use it consistently everywhere in the spec file.

- I don't think it is an acceptable policy that the spec file can build the RPM for SUSE too. You need to have a separate spec file for that (and submit it somewhere else). Sorry.
Comment 3 David Timms 2008-07-13 15:19:50 CEST
Kelly: are you still keen to get emuexec into rpmfusion ?
Would you like to post the updated spec/srpm with the adjustments suggested by Andrea, so that I can continue the process ?
Comment 4 David Timms 2008-11-22 14:27:59 CET
Is it time to close this review wontfix, or is the reporter still interested ?
Comment 5 Andrea Musuruane 2008-12-15 13:57:15 CET
Closing as WONTFIX.

If the original packager wants to restart the review process then he can reopen this bug.