Bug 324 (rt3070-kmod) - rt3070-kmod: Kernel module for wireless devices with Ralink's rt307x chipsets
Summary: rt3070-kmod: Kernel module for wireless devices with Ralink's rt307x chipsets
Status: RESOLVED FIXED
Alias: rt3070-kmod
Product: Package Reviews
Classification: Unclassified
Component: Review Request (show other bugs)
Version: Current
Hardware: All GNU/Linux
: P5 normal
Assignee: Thorsten Leemhuis
URL:
Depends on:
Blocks: RF_ACCEPT
  Show dependency treegraph
 
Reported: 2009-01-15 20:50 CET by Orcan Ogetbil
Modified: 2009-03-16 01:18 CET (History)
1 user (show)

See Also:
namespace:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Orcan Ogetbil 2009-01-15 20:50:10 CET
kmod:
SPEC: http://oget.fedorapeople.org/review/rt3070-kmod.spec
SRPM: http://oget.fedorapeople.org/review/rt3070-kmod-2.0.1.0-1.fc10.src.rpm

common:
SPEC: http://oget.fedorapeople.org/review/rt3070.spec
SRPM: http://oget.fedorapeople.org/review/rt3070-2.0.1.0-1.fc10.src.rpm

rpmlint:
W: no-documentation
Docs are in common package

W: summary-not-capitalized rt3070 kernel module(s) for 2.6.27.9-73.fc9.x86_64
That is because the module name is not capitalized itself (consistent with rt28x0 packages)

W: unstripped-binary-or-object rt3070sta.ko
can be ignored

-------------------------------------------------------------------------------
This is my candidate for the crappiest Linux driver ever created. They basically took the rt2870 driver and modified it to support rt3070. There is nothing wrong for them with stealing their own code. But there were a few issues that I had to solve:

- For some reason they took an older rt2870 driver version and modified it. Hence the driver will not compile for Fedora kernels 2.6.25 and newer. So I had the re-introduce our iwe-stream patch.

- They did not even bother to change the filenames or variable names in the code. The code says "rt2870" but it actually means "rt3070". Confusing. I had to rename the RT2870STA.DAT file to  RT3070STA.DAT to avoid conflicts with our rt2870 kmod.

Other than these two things, both the common and the kmod package is identical to our rt2870 packages in rpmfusion.


I admit that this package is crap. But still, there might be people who can benefit from it.
Comment 1 Thorsten Leemhuis 2009-02-21 14:47:47 CET
APPROVED
Comment 2 Orcan Ogetbil 2009-02-21 23:18:58 CET
Package CVS request
======================
Package Name: rt3070
Short Description: Common files for RaLink rt3070 kernel driver
Owners: oget
Branches: F-10
InitialCC:
----------------------
License tag: free



Package CVS request
======================
Package Name: rt3070-kmod
Short Description: Kernel module for wireless devices with Ralink's rt307x chipsets
Owners: oget
Branches: F-10
InitialCC:
----------------------
License tag: free
Comment 3 Thorsten Leemhuis 2009-02-22 09:58:48 CET
(In reply to comment #2)
> Package CVS request
done
Comment 4 Orcan Ogetbil 2009-03-16 01:18:52 CET
package is in the repositories. closing the bug.